Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210144411
Thank you for merging, @rxin !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12312
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210136555
Thanks - merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210117547
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210117548
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210117221
**[Test build #55830 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55830/consoleFull)**
for PR 12312 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210109306
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210109308
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210109018
**[Test build #55826 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55826/consoleFull)**
for PR 12312 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210084938
**[Test build #55830 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55830/consoleFull)**
for PR 12312 at commit
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59764270
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -519,22 +519,28 @@ object LikeSimplification
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59763152
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -519,22 +519,28 @@ object LikeSimplification extends
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210078145
I updated to use `pattern`, `prefix`, `postfix`, and **`infix`** (as a
similar manner).
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-210077495
**[Test build #55826 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55826/consoleFull)**
for PR 12312 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59760399
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -529,6 +530,11 @@ object LikeSimplification extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59760094
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -529,6 +530,11 @@ object LikeSimplification
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59759998
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -529,6 +530,11 @@ object LikeSimplification
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59758032
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -529,6 +530,11 @@ object LikeSimplification extends
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59757742
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -529,6 +530,11 @@ object LikeSimplification extends
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-209837404
Hi, @rxin .
For `LikeSimplification`, is there something to do more?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-209048617
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-209048612
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-209048186
**[Test build #55618 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55618/consoleFull)**
for PR 12312 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-209011789
**[Test build #55618 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/55618/consoleFull)**
for PR 12312 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-209011439
Hi, @rxin . Sorry for late response.
I added comments and changed the testcase name according to your comments.
Thank you for review!
---
If your project
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59412120
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LikeSimplificationSuite.scala
---
@@ -61,6 +61,20 @@ class
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59412030
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -529,6 +530,9 @@ object LikeSimplification
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59317551
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/LikeSimplificationSuite.scala
---
@@ -61,6 +61,20 @@ class
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12312#discussion_r59317529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -529,6 +530,9 @@ object LikeSimplification extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-208660934
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-208660935
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-208660799
**[Test build #5 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)**
for PR 12312 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12312#issuecomment-208632627
**[Test build #5 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/5/consoleFull)**
for PR 12312 at commit
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12312
[SPARK-14545][SQL] Improve `LikeSimplification` by adding `a%b` rule
## What changes were proposed in this pull request?
Current `LikeSimplification` handles the following four
34 matches
Mail list logo
