Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-214459899
Awesome. Thank you! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12316
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-214016276
OK thanks - I'm going to merge this. The test coverage is too excessive
here. I'm going to remove most of the test cases before merging.
---
If your project is set up
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-213927486
@rxin it being a bit on the esoteric side and setting a precedence are my
minor objections. I am fine putting this in given the size and impact this has
on the code
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-213892774
@hvanhovell Can you think of any downsides if we support this? It is a
little bit esoteric. The main one I can think of is whether this would set a
precedent in that a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-212316779
**[Test build #2834 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2834/consoleFull)**
for PR 12316 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-212283550
**[Test build #2834 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2834/consoleFull)**
for PR 12316 at commit
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-212281661
@rxin gentle ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user jliwork commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-209606539
@rxin Microsoft SQL Server, IBM DB2 and Sybase Adaptive Server support
them.
https://msdn.microsoft.com/en-us/library/ms188074.aspx
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-209247018
Can you summarize the list of database systems that support this syntax?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-209244788
I am not nessecarily against this but I find these quite confusing. Why not
just write `>=` or `<=`?
The PR itself looks pretty solid.
---
If your project
Github user jliwork commented on a diff in the pull request:
https://github.com/apache/spark/pull/12316#discussion_r59323956
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -1432,4 +1432,15 @@ class DataFrameSuite extends QueryTest with
Github user gatorsmile commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-208677145
FYI, MS SQL Server supports these operators:
https://msdn.microsoft.com/en-us/library/ms188074.aspx
---
If your project is set up for it, you can reply to this
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-208663567
Can you trigger the jenkin test? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-208663019
No let's not do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-208662276
@rxin Do we need to add these operators to dsl?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12316#discussion_r59310976
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -1432,4 +1432,15 @@ class DataFrameSuite extends QueryTest with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12316#issuecomment-208660462
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jliwork opened a pull request:
https://github.com/apache/spark/pull/12316
[SPARK-14548][SQL] Support not greater than and not less than operator in
Spark SQL
## What changes were proposed in this pull request?
!< means not less than which is equivalent to >=
19 matches
Mail list logo
