Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215310532
Hmm.
@vanzin I think you have a point. There are few things that can be done but
not sure if they will simplify without reducing the flexibility. I will
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12641
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215171842
Sure, I'll merge this to master.
But still I'd really suggest cleaning up `ExternalClusterManager`, because
it's a really confusing API. It really should be a
Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215069609
@rxin @vanzin Can we merge this now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215067932
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215067936
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215067751
**[Test build #57117 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57117/consoleFull)**
for PR 12641 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215043747
**[Test build #57117 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57117/consoleFull)**
for PR 12641 at commit
Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215043226
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215039416
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215039418
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215039259
**[Test build #57107 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57107/consoleFull)**
for PR 12641 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215009667
**[Test build #57107 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57107/consoleFull)**
for PR 12641 at commit
Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215009140
Build again failed with some unrelated sporadic error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-215009160
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214984339
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214984228
**[Test build #57087 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57087/consoleFull)**
for PR 12641 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214984341
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214969466
**[Test build #57087 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57087/consoleFull)**
for PR 12641 at commit
Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214969001
test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214811893
> I think the scheduler and backend creation may depend on the masterURL
Yeah but that's already available in the SparkContext. It just feels
redundant (as in,
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214607771
**[Test build #56956 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56956/consoleFull)**
for PR 12641 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214607778
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-21460
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214606828
**[Test build #56956 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56956/consoleFull)**
for PR 12641 at commit
Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214606466
@vanzin @rxin Thanks for commenting.
Incorporated review comments apart from the masterURL comment. Regarding
the masterURL being part of API, I think the
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214540648
I think the API looks a little clunky (and that's mostly because the code
it's trying to abstract is a little clunky itself), but as far as this change
goes, it looks
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12641#discussion_r60996892
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClusterManager.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12641#discussion_r60996696
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClusterManager.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12641#discussion_r60996595
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClusterManager.scala
---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12641#discussion_r60996505
--- Diff:
core/src/test/scala/org/apache/spark/SparkContextSchedulerCreationSuite.scala
---
@@ -135,7 +135,7 @@ class SparkContextSchedulerCreationSuite
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214536946
LGTM.
cc @vanzin and @tgravescs for a quick look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-21412
**[Test build #2866 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2866/consoleFull)**
for PR 12641 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214137576
**[Test build #2866 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2866/consoleFull)**
for PR 12641 at commit
Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214129927
Looks like the failing test is related to this JIRA: SPARK-13693. I have
reopened it.
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214126461
**[Test build #2865 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2865/consoleFull)**
for PR 12641 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214100423
**[Test build #2865 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2865/consoleFull)**
for PR 12641 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214032661
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214032659
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214032607
**[Test build #56852 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56852/consoleFull)**
for PR 12641 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214023762
**[Test build #56852 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56852/consoleFull)**
for PR 12641 at commit
Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-214023638
@rxin , your comments made sense and I have made the respective changes.
Please review.
---
If your project is set up for it, you can reply to this email and have
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12641#discussion_r60835072
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/YarnClusterManager.scala ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12641#discussion_r60835060
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/YarnClusterManager.scala ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12641#discussion_r60835052
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/YarnClusterManager.scala ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12641#discussion_r60834795
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/YarnClusterManager.scala ---
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-213831188
cc @vanzin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-213829463
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-213829467
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-213828846
**[Test build #56807 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56807/consoleFull)**
for PR 12641 at commit
Github user hbhanawat commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-213805039
@rxin Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12641#issuecomment-213804431
**[Test build #56807 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56807/consoleFull)**
for PR 12641 at commit
GitHub user hbhanawat opened a pull request:
https://github.com/apache/spark/pull/12641
[SPARK-14729][Scheduler] Refactored YARN scheduler creation code to use
newly added ExternalClusterManager
## What changes were proposed in this pull request?
With the addition of
53 matches
Mail list logo
