[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213567775 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213567771 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213567556 **[Test build #56715 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56715/consoleFull)** for PR 12600 at commit

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213565318 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213565316 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213565062 **[Test build #56714 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56714/consoleFull)** for PR 12600 at commit

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213562402 Merging this into master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213562111 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213562108 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213561607 **[Test build #56713 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56713/consoleFull)** for PR 12600 at commit

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213542932 **[Test build #56715 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56715/consoleFull)** for PR 12600 at commit

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213539712 Please add comments to `doPrepare` to mention the lock. Otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213537141 **[Test build #56714 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56714/consoleFull)** for PR 12600 at commit

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12600#discussion_r60779639 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -187,11 +187,11 @@ abstract class SparkPlan extends

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12600#discussion_r60779425 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -187,11 +187,11 @@ abstract class SparkPlan extends

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213531619 **[Test build #56713 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56713/consoleFull)** for PR 12600 at commit

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread zsxwing
Github user zsxwing commented on a diff in the pull request: https://github.com/apache/spark/pull/12600#discussion_r60778555 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala --- @@ -187,11 +187,11 @@ abstract class SparkPlan extends

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread zsxwing
Github user zsxwing commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213529482 So `SparkPlan` must be thread-safe? Looks `subqueryResults` is not protected. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213287306 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213287309 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-22 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213286426 **[Test build #56648 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56648/consoleFull)** for PR 12600 at commit

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-21 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213257569 Is there a way to create a test case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-21 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213257260 **[Test build #56648 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56648/consoleFull)** for PR 12600 at commit

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-21 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/12600#issuecomment-213257084 cc @zsxwing @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-14791] [SQL] fix risk condition between...

2016-04-21 Thread davies
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/12600 [SPARK-14791] [SQL] fix risk condition between broadcast and subquery ## What changes were proposed in this pull request? SparkPlan.prepare() could be called in different threads