Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12592
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213889929
LGTM. Thanks, merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213653499
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213653500
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213653449
**[Test build #56762 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56762/consoleFull)**
for PR 12592 at commit
[`532a69c`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213643497
**[Test build #56762 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56762/consoleFull)**
for PR 12592 at commit
[`532a69c`](https://gi
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213570739
LGTM except some nits and the style issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12592#discussion_r60793559
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -19,72 +19,129 @@ package org.apache.spark.sql.streaming
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12592#discussion_r60793404
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -205,165 +262,139 @@ class FileStreamSourceSuite extends
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/12592#discussion_r60793400
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -375,10 +406,10 @@ class FileStreamSourceStressTestSuite
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213202897
@zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213201193
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213201198
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213201183
**[Test build #56625 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56625/consoleFull)**
for PR 12592 at commit
[`48f1e6a`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213200949
**[Test build #56625 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56625/consoleFull)**
for PR 12592 at commit
[`48f1e6a`](https://gi
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/12592#discussion_r60679517
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala ---
@@ -95,20 +89,18 @@ trait StreamTest extends QueryTest with Timeouts {
/
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/12592#discussion_r60679490
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/StreamTest.scala ---
@@ -67,12 +67,6 @@ import org.apache.spark.util.Utils
*/
trait StreamTest
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/12592#discussion_r60679327
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -369,6 +369,7 @@ class StreamExecution(
def awai
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213190125
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213190118
**[Test build #56621 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56621/consoleFull)**
for PR 12592 at commit
[`ef65ad7`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213190121
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12592#issuecomment-213189615
**[Test build #56621 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56621/consoleFull)**
for PR 12592 at commit
[`ef65ad7`](https://gi
GitHub user tdas opened a pull request:
https://github.com/apache/spark/pull/12592
[SPARK-14833][SQL][STREAMING][TEST] Refactor StreamTests to test for source
fault-tolerance correctly.
## What changes were proposed in this pull request?
Current StreamTest allows testing of
23 matches
Mail list logo
