[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-18 Thread ericl
Github user ericl commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-220148117 @davies @rxin sounds good I also added a before/after result of sorting nullable longs in the PR description. --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-220139382 Yea this should not go into 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-18 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-220112381 @ericl Since this is a performance improvement for a special case (nullable LongType), the changes are not trivial, should we target this to 2.1 release? --- If your

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-18 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219956800 Any benchmark data you can include? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219922327 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219922326 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-21990 **[Test build #58736 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58736/consoleFull)** for PR 13161 at commit

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219921050 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219921049 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14851] [Core] Support radix sort with n...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13161#issuecomment-219920955 **[Test build #58735 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58735/consoleFull)** for PR 13161 at commit