GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12632
[SPARK-14868] Enable NewLineAtEofChecker in checkstyle and fix lint-java
errors
## What changes were proposed in this pull request?
Spark uses `NewLineAtEofChecker` rule in Scala by ScalaStyle. And, most
Java code also comply with the rule. This PR aims to enforce the same rule
`NewlineAtEndOfFile` by CheckStyle explicitly. Also, this fixes lint-java
errors since SPARK-14465. The followings are the items.
- Adds a new line at the end of the files (19 files)
- Fixes 25 lint-java errors (12 RedundantModifier, 6 **ArrayTypeStyle**, 2
LineLength, 2 UnusedImports, 2 RegexpSingleline, 1 ModifierOrder)
## How was this patch tested?
After the Jenkins test succeeds, `dev/lint-java` shows no errors.
(Currently, Jenkins dose not run lint-java.)
```bash
$ dev/lint-java
Using `mvn` from path: /usr/local/bin/mvn
Checkstyle checks passed.
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-14868
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12632.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12632
----
commit d20e16764c4ae4e7a645df3db650b9872a075eda
Author: Dongjoon Hyun <dongj...@apache.org>
Date: 2016-04-23T05:56:31Z
[SPARK-14868] Enable NewLineAtEofChecker in checkstyle and fix lint-java
errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
