[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/12645 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread yhuai
Github user yhuai commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213892106 OK. Thanks. Will send out a follow-up pr. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60839199 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213891570 Most of the problems I pointed out also existed in the old code, so feel free to merge this one and submit a follow-up pr to address them. --- If your project is set up

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60839135 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60839130 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60839110 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60839082 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60839067 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60838889 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60838884 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60838834 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60838810 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60838743 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60838739 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,452 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213857179 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213857174 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213857074 **[Test build #56818 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56818/consoleFull)** for PR 12645 at commit

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213856567 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213856566 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213856283 **[Test build #56816 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56816/consoleFull)** for PR 12645 at commit

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213850298 **[Test build #56818 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56818/consoleFull)** for PR 12645 at commit

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213849516 **[Test build #56816 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56816/consoleFull)** for PR 12645 at commit

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213848524 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213848523 **[Test build #56815 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56815/consoleFull)** for PR 12645 at commit

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213848525 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/12645#issuecomment-213847597 **[Test build #56815 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56815/consoleFull)** for PR 12645 at commit

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60835970 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,436 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread yhuai
Github user yhuai commented on a diff in the pull request: https://github.com/apache/spark/pull/12645#discussion_r60835975 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/createDataSourceTables.scala --- @@ -0,0 +1,436 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-14879] [SQL] Move CreateMetastoreDataSo...

2016-04-23 Thread yhuai
GitHub user yhuai opened a pull request: https://github.com/apache/spark/pull/12645 [SPARK-14879] [SQL] Move CreateMetastoreDataSource and CreateMetastoreDataSourceAsSelect to sql/core ## What changes were proposed in this pull request? CreateMetastoreDataSource and