Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214885371
Oh, thank YOU, @jkbradley .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12676
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214883910
LGTM
I'll merge this with master
Thanks (and thanks for pushing back)!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214883741
Oh, I apologize; I missed the TODO removal. You're right; that should have
been removed previously when the sc.parallelize call was changed to use 1
partition.
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214842843
In fact, I didn't try to change that if it's just a style problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214842611
If you think so, it's okay, @jkbradley .
But, if you don't mind, could you remove those TODO by yourself.
Do you have any reason to maintain that?
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214838396
This isn't really changing anything, and I actually think this makes the DF
creation less similar to most spark.mllib save methods in terms of code style.
I'd
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214822460
Hi, @mengxr .
Could you review this too?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214810333
Thank you for review, @MLnick !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214634427
LGTM.
("save/load" test case in `LinearRegressionSuite` covers this)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214605818
Hi, @jkbradley .
Could you review this PR when you have some time?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214576212
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214576210
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214576138
**[Test build #56947 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56947/consoleFull)**
for PR 12676 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12676#issuecomment-214570724
**[Test build #56947 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/56947/consoleFull)**
for PR 12676 at commit
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12676
[SPARK-14907][MLLIB] Use repartition in GLMRegressionModel.save
## What changes were proposed in this pull request?
This PR changes `GLMRegressionModel.save` function like the
16 matches
Mail list logo
