Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61987501
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object SparkSession
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216404112
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216404113
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216403979
**[Test build #57566 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57566/consoleFull)**
for PR 12830 at commit
[`0005a3d`](https://g
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61821953
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object SparkSession {
Github user tedyu commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61821150
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object SparkSession
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12830
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216383981
**[Test build #57566 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57566/consoleFull)**
for PR 12830 at commit
[`0005a3d`](https://gi
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216383875
Thanks - going to merge this. I added removing the existing withHiveSupport
as a TODO in the pr description.
---
If your project is set up for it, you can reply to this
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61805011
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object SparkSession {
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61804989
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object SparkSession {
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216352389
LGTM. This is beautiful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61797568
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object SparkSes
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61797056
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object SparkSes
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61797058
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object SparkSes
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61707542
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object Spark
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61706770
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object Spark
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216106479
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216106483
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216106407
**[Test build #57501 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57501/consoleFull)**
for PR 12830 at commit
[`8172d91`](https://g
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61702820
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object SparkSession {
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/12830#discussion_r61702208
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
---
@@ -635,6 +642,122 @@ class SparkSession private(
object Spark
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216102730
Yes, right. And, this can reduce the `import` statement for `SparkConf` and
`SparkContext` for those people. It become much simpler. Cool. I will update my
PR acc
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216102470
Yes. Technically we don't really reduce the line length, but definitely
reduces the number of concepts people need to use if they are just using
DataFrame/Dataset.
---
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216102294
Thank you for notifying me. It looks good to me. Then, the three-line
pattern will be replace into one factory statement, right?
**Spark 1.x**
```
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216101059
**[Test build #57501 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57501/consoleFull)**
for PR 12830 at commit
[`8172d91`](https://gi
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/12830#issuecomment-216100989
cc @yhuai @andrewor14
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/12830
[SPARK-15052][SQL] Use builder pattern to create SparkSession
## What changes were proposed in this pull request?
This patch creates a builder pattern for creating SparkSession. The new
code is un
28 matches
Mail list logo
