Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-17352
ping @yanboliang ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-221962515
ping?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-221179828
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-221179827
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-221179741
**[Test build #59184 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59184/consoleFull)**
for PR 12889 at commit
[`020c096`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-221174436
**[Test build #59184 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59184/consoleFull)**
for PR 12889 at commit
[`020c096`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-221167951
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-221167954
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-221167902
**[Test build #59181 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59181/consoleFull)**
for PR 12889 at commit
[`6e35559`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-221166701
**[Test build #59181 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59181/consoleFull)**
for PR 12889 at commit
[`6e35559`](https://gi
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r63323247
--- Diff: python/pyspark/ml/regression.py ---
@@ -708,7 +710,7 @@ def _create_model(self, java_model):
@inherit_doc
-class DecisionTreeMo
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r63321004
--- Diff: python/pyspark/ml/regression.py ---
@@ -708,7 +710,7 @@ def _create_model(self, java_model):
@inherit_doc
-class DecisionTreeMod
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-219179609
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-219179607
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-219179550
**[Test build #58594 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58594/consoleFull)**
for PR 12889 at commit
[`f5c69f1`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-219177910
**[Test build #58594 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58594/consoleFull)**
for PR 12889 at commit
[`f5c69f1`](https://gi
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-217755535
Updated the classification models that do the mixing in based on the
current inheritance in Scala side. I can follow up with more regression changes
if no one takes ove
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-217545042
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-217545040
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-217544938
**[Test build #58023 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58023/consoleFull)**
for PR 12889 at commit
[`e3b01f5`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-217542363
**[Test build #58023 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58023/consoleFull)**
for PR 12889 at commit
[`e3b01f5`](https://gi
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r62381355
--- Diff: python/pyspark/ml/regression.py ---
@@ -708,7 +710,7 @@ def _create_model(self, java_model):
@inherit_doc
-class DecisionTreeMo
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-217363886
```numFeatures``` in ```PredictionModel``` at Scala side, so all classes
extends from ```PredictionModel```(at Scala side) should be mixed-in it.
```numClasses```
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r62294700
--- Diff: python/pyspark/ml/classification.py ---
@@ -1118,7 +1142,8 @@ def getBlockSize(self):
return self.getOrDefault(self.blockSize)
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r62294714
--- Diff: python/pyspark/ml/regression.py ---
@@ -708,7 +710,7 @@ def _create_model(self, java_model):
@inherit_doc
-class DecisionTre
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r62294597
--- Diff: python/pyspark/ml/classification.py ---
@@ -581,8 +602,11 @@ def _create_model(self, java_model):
@inherit_doc
-class Decisi
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r62178821
--- Diff: python/pyspark/ml/regression.py ---
@@ -708,7 +710,7 @@ def _create_model(self, java_model):
@inherit_doc
-class DecisionTreeMod
Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12889#discussion_r62178436
--- Diff: python/pyspark/ml/classification.py ---
@@ -581,8 +602,11 @@ def _create_model(self, java_model):
@inherit_doc
-class DecisionTr
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-217093477
cc @yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-216760706
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-216760705
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-216760656
**[Test build #57726 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57726/consoleFull)**
for PR 12889 at commit
[`c1961ae`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12889#issuecomment-216759233
**[Test build #57726 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57726/consoleFull)**
for PR 12889 at commit
[`c1961ae`](https://gi
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/12889
[SPARK-15113][PySpark][ML] Add missing num features num classes
## What changes were proposed in this pull request?
Add missing `numFeatures` and `numClasses` to the wrapped Java models in
34 matches
Mail list logo
