Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-221126837
cc @jkbradley ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-220426013
Personally I'm in favor of #2 or #3 since they would both give us nice
looking documentation on par with that of the Scala side.
---
If your project is set up for it,
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-220219840
@jkbradley @yanboliang @holdenk @sethah let's discuss the issue of defaults
in param doc (refer
https://github.com/apache/spark/pull/13148#discussion_r63600571) on this
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-220117199
@yanboliang thanks for pointing that out. I'll continue some discussion
over there (tl;dr - imho PyDoc is also a thing that matters).
---
If your project is set up
Github user yanboliang commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-220070510
Refer @jkbradley 's comments for #13148 which is related to default value
statement in param build-in doc:
```
No need to state default in built-in doc.
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-218547004
@MLnick what do you think of this approach?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-218234260
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-218234267
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-218234130
**[Test build #58244 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58244/consoleFull)**
for PR 12914 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-218230292
**[Test build #58244 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58244/consoleFull)**
for PR 12914 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-218229038
I gave it some more thought over coffee - I can remove much of the
duplication if we want.
---
If your project is set up for it, you can reply to this email and have
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-218187728
Darn - it would have been a really simple solution.
I'm not against having them as properties - the issue is the duplication
you see, e.g.
```
_maxIter
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-218189988
Or we could go back to the first solution I proposed in this PR which
duplicates the values when someone calls explainParam but is otherwise a
small change
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217951794
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217951795
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217951605
**[Test build #58154 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58154/consoleFull)**
for PR 12914 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217947835
**[Test build #58154 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58154/consoleFull)**
for PR 12914 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217938714
We could change these to be properties so they have proper docstrings but
technically that would be an API breaking change.
---
If your project is set up for it, you
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217933755
@MLnick Turns out thats a sphinx extension since they don't have proper
docstrings so it isn't inherited and we can't really do much about that so I
don't think that
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217919508
seems like that doesn't work with inheritance out of the box, I'll do some
poking.
---
If your project is set up for it, you can reply to this email and have your
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217913130
@MLnick - That seems like a good solution without needing any regex. It
does look a bit odd in the generated docs but all of the current params look a
bit odd in the
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217875812
@holdenk I'd prefer for us to find a way to document the default value in
the API docs without resorting to stripping it out with a regex.
This works for
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217755456
Any more ideas on if this is something we want (cc @davies ?)? This one
only does shared params so I'd like to follow it up for the non-shared params
as well. I think
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217348813
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217348812
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217348761
**[Test build #57961 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57961/consoleFull)**
for PR 12914 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217348026
**[Test build #57961 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57961/consoleFull)**
for PR 12914 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217344576
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217344567
**[Test build #57958 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57958/consoleFull)**
for PR 12914 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217344578
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217343853
**[Test build #57958 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57958/consoleFull)**
for PR 12914 at commit
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12914#discussion_r62286043
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -58,6 +61,9 @@ def __init__(self):
if defaultValueStr is not None:
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12914#discussion_r62285930
--- Diff: python/pyspark/ml/param/_shared_params_code_gen.py ---
@@ -58,6 +61,9 @@ def __init__(self):
if defaultValueStr is not None:
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12914#discussion_r62285684
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -280,7 +281,9 @@ def explainParam(self, param):
else:
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12914#discussion_r62285526
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -280,7 +281,9 @@ def explainParam(self, param):
else:
Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/12914#discussion_r62285048
--- Diff: python/pyspark/ml/param/__init__.py ---
@@ -280,7 +281,9 @@ def explainParam(self, param):
else:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217320267
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217320265
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217320135
**[Test build #57938 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57938/consoleFull)**
for PR 12914 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217318620
**[Test build #57938 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57938/consoleFull)**
for PR 12914 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217295137
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217295140
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217295109
**[Test build #57926 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57926/consoleFull)**
for PR 12914 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217292797
**[Test build #57926 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57926/consoleFull)**
for PR 12914 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217291600
MiMa failure is clearly unrelated, jenkins retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217285101
I'm not sure what changes went into python docs, but it seems that from 1.6
to now we made a change that does NOT show the constructor for Python classes,
and hence
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217249358
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217249307
**[Test build #57910 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57910/consoleFull)**
for PR 12914 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217249363
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217245973
**[Test build #57910 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57910/consoleFull)**
for PR 12914 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217204458
@MLnick I could change the `explainParam` call to strip out the existing
default so it shows up in both the HTML docs and looks reasonable in
Github user MLnick commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217134578
@holdenk one potential issue that I've found with including the default
value in the param "help" is that it then gets duplicated if users call
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217093446
cc @yanboliang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217037170
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217037167
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217037091
**[Test build #57815 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57815/consoleFull)**
for PR 12914 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217033932
**[Test build #57815 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/57815/consoleFull)**
for PR 12914 at commit
Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12914#issuecomment-217032893
cc @sethah & @keypointt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user holdenk opened a pull request:
https://github.com/apache/spark/pull/12914
[SPARK-15130][PySpark][ML][DOCS] pyspark expose default params in ml
pipeline
## What changes were proposed in this pull request?
Add default values to shared params in ML pipeline.
59 matches
Mail list logo
