Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/12989
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/12989#issuecomment-218925573
LGTM. Merging this to master, branch-2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/12989#issuecomment-218924180
@sun-rui Taking a final pass now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/12989#issuecomment-218923967
@shivaram,could you merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62716138
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2070,6 +2072,16 @@ test_that("dapply() on a DataFrame", {
rownames(expected) <- NULL
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62633115
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2070,6 +2072,16 @@ test_that("dapply() on a DataFrame", {
rownames(expected) <- NULL
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62619994
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2070,6 +2072,16 @@ test_that("dapply() on a DataFrame", {
rownames(expected) <- NULL
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62619916
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2070,6 +2072,16 @@ test_that("dapply() on a DataFrame", {
rownames(expected) <- NULL
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62601918
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2070,6 +2072,16 @@ test_that("dapply() on a DataFrame", {
rownames(expected) <- NULL
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62601728
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1197,21 +1215,57 @@ setMethod("summarize",
setMethod("dapply",
signature(x = "SparkDataFrame", func
Github user sun-rui commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62601678
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1197,21 +1215,57 @@ setMethod("summarize",
setMethod("dapply",
signature(x = "SparkDataFrame", func
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62592006
--- Diff: R/pkg/inst/tests/testthat/test_sparkSQL.R ---
@@ -2070,6 +2072,16 @@ test_that("dapply() on a DataFrame", {
rownames(expected) <- NULL
Github user felixcheung commented on the pull request:
https://github.com/apache/spark/pull/12989#issuecomment-218014582
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62587316
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1197,21 +1215,57 @@ setMethod("summarize",
setMethod("dapply",
signature(x = "SparkDataFrame", f
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62587150
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1197,21 +1215,57 @@ setMethod("summarize",
setMethod("dapply",
signature(x = "SparkDataFrame", f
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62587086
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1197,21 +1215,57 @@ setMethod("summarize",
setMethod("dapply",
signature(x = "SparkDataFrame", f
Github user NarineK commented on a diff in the pull request:
https://github.com/apache/spark/pull/12989#discussion_r62576985
--- Diff: R/pkg/R/DataFrame.R ---
@@ -1197,21 +1215,57 @@ setMethod("summarize",
setMethod("dapply",
signature(x = "SparkDataFrame", func
Github user sun-rui commented on the pull request:
https://github.com/apache/spark/pull/12989#issuecomment-21755
cc @shivaram, @felixcheung , @NarineK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12989#issuecomment-217713498
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/12989#issuecomment-217713494
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12989#issuecomment-217713372
**[Test build #58104 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58104/consoleFull)**
for PR 12989 at commit
[`a728af5`](https://g
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/12989#issuecomment-217712089
**[Test build #58104 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58104/consoleFull)**
for PR 12989 at commit
[`a728af5`](https://gi
GitHub user sun-rui opened a pull request:
https://github.com/apache/spark/pull/12989
[SPARK-15202][SPARKR] add dapplyCollect() method for DataFrame in SparkR.
## What changes were proposed in this pull request?
dapplyCollect() applies an R function on each partition of a Sp
23 matches
Mail list logo
