[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13024 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218295471 Thanks, merging into master 2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13024#discussion_r62754734 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -677,8 +677,9 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13024#discussion_r62754706 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala --- @@ -677,8 +677,9 @@ private[hive] class HiveClientImpl(

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218288021 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218288018 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218287633 **[Test build #58259 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58259/consoleFull)** for PR 13024 at commit [`f3842f2`](https://g

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218261494 **[Test build #58259 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58259/consoleFull)** for PR 13024 at commit [`f3842f2`](https://gi

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13024#discussion_r62733179 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/functionResources.scala --- @@ -20,16 +20,24 @@ package org.apache.spark.sql.

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread techaddict
Github user techaddict commented on a diff in the pull request: https://github.com/apache/spark/pull/13024#discussion_r62732815 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/functionResources.scala --- @@ -20,16 +20,24 @@ package org.apache.spark.sql.

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218257432 Just minor comments. LGTM overall. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13024#discussion_r62731779 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -636,10 +636,8 @@ class SessionCatalog( *

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13024#discussion_r62731677 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/functionResources.scala --- @@ -20,16 +20,24 @@ package org.apache.spark.sql.

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13024#discussion_r62731630 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/functionResources.scala --- @@ -20,16 +20,24 @@ package org.apache.spark.sql.

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218137264 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218137262 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218137050 **[Test build #58230 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58230/consoleFull)** for PR 13024 at commit [`0de5f84`](https://g

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218118749 **[Test build #58230 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58230/consoleFull)** for PR 13024 at commit [`0de5f84`](https://gi

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218105273 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218105275 Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218105268 **[Test build #58227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58227/consoleFull)** for PR 13024 at commit [`8c2f33c`](https://g

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218104344 **[Test build #58227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58227/consoleFull)** for PR 13024 at commit [`8c2f33c`](https://gi

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/13024#issuecomment-218103693 cc: @yhuai --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] spark pull request: [SPARK-15249][SQL] Use FunctionResource instea...

2016-05-10 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/13024 [SPARK-15249][SQL] Use FunctionResource instead of (String, String) in CreateFunction and CatalogFunction for resource ## What changes were proposed in this pull request? Use FunctionResourc