[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218932753 **[Test build #58534 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58534/consoleFull)** for PR 13048 at commit [`0f86ce6`](https://gi

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218931580 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218931581 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218931457 **[Test build #58528 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58528/consoleFull)** for PR 13048 at commit [`17bca76`](https://g

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63120588 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63120114 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218921451 **[Test build #58528 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58528/consoleFull)** for PR 13048 at commit [`17bca76`](https://gi

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r63117779 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218840123 Sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218695548 @rxin Sure. How about including `ORCOptions` This will be almost identical with `ParquetOptions`? --- If your project is set up for it, you can reply to this email

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218694817 Can we do this only for JDBC? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-12 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218694751 hm for some of these that has one or two options I think it might be overkill. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218440525 cc @rxin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218438077 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218438075 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218437831 **[Test build #58362 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58362/consoleFull)** for PR 13048 at commit [`7c2b63f`](https://g

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-11 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/13048#discussion_r62825064 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcOptions.scala --- @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Fou

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13048#issuecomment-218420960 **[Test build #58362 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58362/consoleFull)** for PR 13048 at commit [`7c2b63f`](https://gi

[GitHub] spark pull request: [SPARK-15267][SQL] Refactor and add some class...

2016-05-11 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/spark/pull/13048 [SPARK-15267][SQL] Refactor and add some classes for options in datasources ## What changes were proposed in this pull request? Currently, Parquet, JSON and CSV data sources have a clas