Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221330231
`DefinedByConstructorParams` is a good idea
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221172065
Can we just use DefinedByConstructorParams rather than using case classes?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64327921
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala ---
@@ -58,4 +58,39 @@ class DataFrameComplexTypeSuite extends
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221165640
Sorry we have to revert it as it breaks scala-2.10 build
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221162353
thanks, merging to master and 2.0!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221158001
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221158003
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221157890
**[Test build #59173 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59173/consoleFull)**
for PR 13243 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221147028
**[Test build #59173 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59173/consoleFull)**
for PR 13243 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64318271
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala ---
@@ -58,4 +58,38 @@ class DataFrameComplexTypeSuite extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221083826
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221083825
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221083534
**[Test build #59149 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59149/consoleFull)**
for PR 13243 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64277601
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala ---
@@ -58,4 +58,38 @@ class DataFrameComplexTypeSuite extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-221058608
**[Test build #59149 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59149/consoleFull)**
for PR 13243 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64266488
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala ---
@@ -58,4 +58,38 @@ class DataFrameComplexTypeSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64245614
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala ---
@@ -58,4 +58,38 @@ class DataFrameComplexTypeSuite extends
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64245550
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala ---
@@ -58,4 +58,38 @@ class DataFrameComplexTypeSuite extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220952732
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220952730
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220952549
**[Test build #59126 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59126/consoleFull)**
for PR 13243 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64196573
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,47 @@ case class NewInstance(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64196297
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,47 @@ case class NewInstance(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220935411
**[Test build #59126 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59126/consoleFull)**
for PR 13243 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220902483
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220902485
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220902329
**[Test build #59122 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59122/consoleFull)**
for PR 13243 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64172891
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,47 @@ case class NewInstance(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64172857
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,47 @@ case class NewInstance(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220890649
**[Test build #59122 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59122/consoleFull)**
for PR 13243 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220883772
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220883773
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220883664
**[Test build #59118 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59118/consoleFull)**
for PR 13243 at commit
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64166173
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,54 @@ case class NewInstance(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64164066
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,55 @@ case class NewInstance(
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220876025
**[Test build #59118 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59118/consoleFull)**
for PR 13243 at commit
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64163700
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,55 @@ case class NewInstance(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64162830
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,55 @@ case class NewInstance(
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64162262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,55 @@ case class NewInstance(
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220844617
mostly LGTM except some minor comments, thanks for working on it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64153183
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,55 @@ case class NewInstance(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64153170
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,55 @@ case class NewInstance(
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13243#discussion_r64153124
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
---
@@ -232,27 +232,55 @@ case class NewInstance(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220840617
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220840619
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220840523
**[Test build #59109 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59109/consoleFull)**
for PR 13243 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220835818
**[Test build #59109 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59109/consoleFull)**
for PR 13243 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220833378
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220833377
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220833313
**[Test build #59098 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59098/consoleFull)**
for PR 13243 at commit
Github user kiszk commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220824933
Let me see the approach, which you proposed, later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220823691
**[Test build #59098 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59098/consoleFull)**
for PR 13243 at commit
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13243#issuecomment-220815424
The fallback approach doesn't look that simple and clean, can you try split
the generated code like we did in `CreateExternalRow`?
---
If your project is set up for
54 matches
Mail list logo
