Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13096
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-220523585
Alright I'm going to merge this in master/2.0. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-220521107
LGTM, thanks for finding this bug!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13096#discussion_r63992991
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1560,7 +1561,14 @@ object EmbedSerializerInFilter
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-220519361
cc @cloud-fan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-220516852
Can you add the jira ticket somewhere as inline comment in the test case
and in the analyzer code?
---
If your project is set up for it, you can reply to this email and
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-219010209
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-219010208
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-219010063
**[Test build #58555 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58555/consoleFull)**
for PR 13096 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-219007546
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-219007550
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-219007314
**[Test build #58553 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58553/consoleFull)**
for PR 13096 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-218992912
**[Test build #58555 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58555/consoleFull)**
for PR 13096 at commit
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13096#discussion_r63153478
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1560,7 +1561,15 @@ object EmbedSerializerInFilter
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13096#discussion_r63153328
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1560,7 +1561,15 @@ object EmbedSerializerInFilter
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13096#discussion_r63152997
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -1560,7 +1561,15 @@ object EmbedSerializerInFilter
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13096#issuecomment-218989593
**[Test build #58553 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58553/consoleFull)**
for PR 13096 at commit
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/13096
[SPARK-15313][SQL] EmbedSerializerInFilter rule should keep exprIds of
output of surrounded SerializeFromObject.
## What changes were proposed in this pull request?
The following code:
18 matches
Mail list logo
