Github user viirya commented on the pull request:
https://github.com/apache/spark/pull/13235#issuecomment-221815313
@ueshin yes. but #12351 is based on some assumptions and seems too
complicated. So it is not merged.
---
If your project is set up for it, you can reply to this email
Github user ueshin commented on the pull request:
https://github.com/apache/spark/pull/13235#issuecomment-221776141
It looks like #12351 is the same issue about whole stage codegen with
`splitExpressions`.
---
If your project is set up for it, you can reply to this email and have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13235#issuecomment-221116748
hm this pull request outlines a problem with whole stage codegen, i.e. it
is too convoluted at the moment and needs cleanup. Looking at the diff it is
difficult to
Github user jurriaan commented on the pull request:
https://github.com/apache/spark/pull/13235#issuecomment-220796543
Thanks! Not sure if I understand it correctly, but what happens when the
whole-stage codegen generates code longer then 64k? Because I thought about
fixing this issue
Github user jurriaan commented on a diff in the pull request:
https://github.com/apache/spark/pull/13235#discussion_r64139152
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2477,6 +2477,30 @@ class SQLQuerySuite extends QueryTest with
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13235#issuecomment-220748210
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13235#issuecomment-220748209
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13235#issuecomment-220748118
**[Test build #59041 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59041/consoleFull)**
for PR 13235 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13235#issuecomment-220736875
**[Test build #59041 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59041/consoleFull)**
for PR 13235 at commit
GitHub user davies opened a pull request:
https://github.com/apache/spark/pull/13235
[SPARK-15327] [SQL] fix split expression in whole stage codegen
## What changes were proposed in this pull request?
Right now, we will split the code for expressions into multiple functions
10 matches
Mail list logo
