[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-19 Thread holdenk
Github user holdenk commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-220446944 @jkbradley see the discussion/proposed solutions on https://github.com/apache/spark/pull/12914 --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-19 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-220442030 LGTM Merging with master and branch-2.0 Thanks! @holdenk We can discuss this Pyspark Params issue more. I agree it will be important to offer users

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-18 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13148#discussion_r63799888 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala --- @@ -39,23 +39,27 @@ private[clustering] trait

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-18 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/13148#discussion_r63789574 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala --- @@ -39,23 +39,27 @@ private[clustering] trait BisectingKMeansParams

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-18 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/13148#discussion_r63756694 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala --- @@ -39,23 +39,27 @@ private[clustering] trait BisectingKMeansParams

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219927964 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219927902 **[Test build #58743 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58743/consoleFull)** for PR 13148 at commit

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219927963 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219923723 **[Test build #58743 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58743/consoleFull)** for PR 13148 at commit

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread jkbradley
Github user jkbradley commented on a diff in the pull request: https://github.com/apache/spark/pull/13148#discussion_r63600571 --- Diff: mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala --- @@ -39,23 +39,27 @@ private[clustering] trait

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219848715 That's the only issue I saw. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread jkbradley
Github user jkbradley commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219846049 I'll take a look now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219684646 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219684645 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219684430 **[Test build #58684 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58684/consoleFull)** for PR 13148 at commit

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13148#issuecomment-219675843 **[Test build #58684 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58684/consoleFull)** for PR 13148 at commit

[GitHub] spark pull request: [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit...

2016-05-17 Thread yanboliang
GitHub user yanboliang opened a pull request: https://github.com/apache/spark/pull/13148 [SPARK-15361] [ML] ML 2.0 QA: Scala APIs audit for clustering ## What changes were proposed in this pull request? Audit Scala API for ml.clustering. Fix some wrong API documentations and