Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221942182
@rxin Thanks for taking the time to review and merging the patch. I have
added the Email to my profile.
---
If your project is set up for it, you can reply
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13150
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221467220
Merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221467315
@Parth-Brahmbhatt you should add the email address you used in your commit
to your github profile, so the commit is associated with your account. Thanks.
---
If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221463522
**[Test build #3017 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3017/consoleFull)**
for PR 13150 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r64504540
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala ---
@@ -68,6 +71,51 @@ class StatisticsSuite extends QueryTest with
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221452802
**[Test build #3017 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/3017/consoleFull)**
for PR 13150 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221452537
Great - thanks.
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221450739
@rxin added a test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r64503327
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +117,31 @@ private[hive] case class
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221417642
This looks good. Just two minor nits. If you can fix those that would be
great.
Also - would it be possible to add a test case?
---
If your project is set up
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r64484127
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +117,31 @@ private[hive] case class MetastoreRelation(
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221390999
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221390997
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221390733
**[Test build #59215 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59215/consoleFull)**
for PR 13150 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221367988
**[Test build #59215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59215/consoleFull)**
for PR 13150 at commit
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221360098
jenkins test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user sameeragarwal commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r64445157
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -113,6 +113,13 @@ object SQLConf {
.longConf
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221356370
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221026594
@sameeragarwal @rxin FYI, Github currently has some latency issues so you
probably can't see the updates.
---
If your project is set up for it, you can
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-221017398
@sameeragarwal Added config option. @rxin can you take a look one more
time?
---
If your project is set up for it, you can reply to this email and
Github user sameeragarwal commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-220734823
@Parth-Brahmbhatt this looks pretty good. However, given that hitting the
underlying filesystem directly can incur a lot of latency (especially in case
of S3),
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63968077
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63968095
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63968104
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63633986
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class MetastoreRelation(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63633968
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class MetastoreRelation(
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63633820
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class MetastoreRelation(
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63628099
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63627565
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63627480
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63626678
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13150#discussion_r63626710
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/MetastoreRelation.scala ---
@@ -114,17 +115,27 @@ private[hive] case class
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/spark/pull/13150
[SPARK-15365] [SQL]: When table size statistics are not available from
metastore, we should fallback to HDFS
## What changes were proposed in this pull request?
Currently if a table
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13150#issuecomment-219793393
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
35 matches
Mail list logo
