Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13158
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220175949
Oh, thank you, @srowen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220175590
Merged to master/2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220173646
Hi, @zsxwing .
Finally, it passes the Jenkins test. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220172814
**[Test build #2993 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2993/consoleFull)**
for PR 13158 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220147151
**[Test build #58803 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58803/consoleFull)**
for PR 13158 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220147478
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220147479
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220145888
**[Test build #2993 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2993/consoleFull)**
for PR 13158 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220144611
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220144607
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220144224
**[Test build #58801 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58801/consoleFull)**
for PR 13158 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220138483
**[Test build #58804 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58804/consoleFull)**
for PR 13158 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220138708
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220137256
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220137024
**[Test build #58800 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58800/consoleFull)**
for PR 13158 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220137257
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220138706
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220112134
**[Test build #58804 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58804/consoleFull)**
for PR 13158 at commit
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220112444
LGTM pending tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220110453
I'm done. You can test locally now with the up-to-date code.
Thank you for review and local testing, @zsxwing !
---
If your project is set up for it, you
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220110786
**[Test build #58803 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58803/consoleFull)**
for PR 13158 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220107972
**[Test build #58801 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58801/consoleFull)**
for PR 13158 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220109621
Oh, wait a moment. I'm testing on refactored method. I'll update the PR
very soon again.
---
If your project is set up for it, you can reply to this email and
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63751712
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220108576
@dongjoon-hyun looks pretty good. Let me try locally.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63750743
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220106807
I see. The `js` files. I'll fix them. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220106461
**[Test build #58800 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58800/consoleFull)**
for PR 13158 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220106059
Oh, did I do that? Sorry, but which file did I do that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zsxwing commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220105660
@dongjoon-hyun could you revert the changes to the file permission?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220105230
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220104417
**[Test build #58789 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58789/consoleFull)**
for PR 13158 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220104622
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220104624
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220076246
**[Test build #58789 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58789/consoleFull)**
for PR 13158 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-220075551
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-22704
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-22568
**[Test build #58767 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58767/consoleFull)**
for PR 13158 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-22705
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63675876
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63675768
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63675265
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63674795
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,7 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-219977961
**[Test build #58767 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58767/consoleFull)**
for PR 13158 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-219977931
@srowen . I updated the PR to use `TimeZone.getDefault()`. Thank you again.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63674132
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/timeline-view.js ---
@@ -26,7 +26,10 @@ function drawApplicationTimeline(groupArray,
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63674102
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63673599
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/timeline-view.js ---
@@ -26,7 +26,10 @@ function drawApplicationTimeline(groupArray,
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63671930
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63667936
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63667773
--- Diff:
core/src/main/resources/org/apache/spark/ui/static/timeline-view.js ---
@@ -26,7 +26,10 @@ function drawApplicationTimeline(groupArray,
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/13158#discussion_r63667392
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala ---
@@ -172,6 +172,8 @@ private[ui] class AllJobsPage(parent: JobsTab) extends
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-219931535
cc @andrewor14 @zsxwing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-219909074
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-219909077
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-219908945
**[Test build #58729 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58729/consoleFull)**
for PR 13158 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-219893989
**[Test build #58729 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58729/consoleFull)**
for PR 13158 at commit
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/13158#issuecomment-219893875
cc @davies
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/13158
[SPARK-15373][WEB UI] Spark UI should show consistent timezones.
## What changes were proposed in this pull request?
Currently, SparkUI shows two timezones in a single page when the
60 matches
Mail list logo
