[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13186 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-24 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-221178042 Great, I'm merging this into master 2.0 thanks for fixing it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-221177993 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-221177992 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-221177827 **[Test build #59182 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59182/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-23 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-221167163 **[Test build #59182 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59182/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-23 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-221057339 @adrian-wang this looks pretty good, just one comment about where the negative index should be handled. --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13186#discussion_r64265938 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -543,6 +543,9 @@ public UTF8String repeat(int times) {

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13186#discussion_r64265705 --- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java --- @@ -543,6 +543,9 @@ public UTF8String repeat(int times) {

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-23 Thread andrewor14
Github user andrewor14 commented on a diff in the pull request: https://github.com/apache/spark/pull/13186#discussion_r64265195 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala --- @@ -518,7 +518,7 @@ case class

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220435752 actually maybe cc @andrewor14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220435143 cc @sameeragarwal for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220300727 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220300728 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220300558 **[Test build #58859 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58859/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220278856 **[Test build #58859 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58859/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220278544 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220270478 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220270481 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220270298 **[Test build #58854 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58854/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220251693 **[Test build #58854 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58854/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220250927 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220250743 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220250746 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220250574 **[Test build #58849 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58849/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220249847 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220249844 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220249656 **[Test build #58847 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58847/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220233159 **[Test build #58849 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58849/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220232622 **[Test build #58847 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58847/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220228251 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220228252 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220228173 **[Test build #58835 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58835/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-18 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13186#issuecomment-220217381 **[Test build #58835 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58835/consoleFull)** for PR 13186 at commit

[GitHub] spark pull request: [SPARK-15397] [SQL] fix string udf locate as h...

2016-05-18 Thread adrian-wang
GitHub user adrian-wang opened a pull request: https://github.com/apache/spark/pull/13186 [SPARK-15397] [SQL] fix string udf locate as hive ## What changes were proposed in this pull request? in hive, `locate("aa", "aaa", 0)` would yield 0, `locate("aa", "aaa", 1)` would