Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221762895
Thank you Andrew , Herman for your input. I am closing this pull request.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user sureshthalamati closed the pull request at:
https://github.com/apache/spark/pull/13305
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221750415
@sureshthalamati I've taken over this patch at #13315 with a different
solution. Thanks for working on this.
---
If your project is set up for it, you can reply to
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221735811
```
scala> sql("CREATE TABLE boxes (length INT, height INT, width INT) USING
parquet")
scala> (1 to 3).map { i => (i, i * 2, i * 3) }.toDF("height", "length",
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221736081
@sureshthalamati I was able to get it working with your example as well. I
think it does work with datasource table. We just need to add a call to
`spark.catalog.ref
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221736590
Actually, it looks like it's a slightly bigger change so we can always do
it in a future patch if you prefer.
---
If your project is set up for it, you can reply to
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221735424
Actually I was able to get `TRUNCATE TABLE` to work on data source tables,
though I have to add a call to `spark.catalog.refershTable` every time after I
call `TRUNC
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221726211
**[Test build #59301 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59301/consoleFull)**
for PR 13305 at commit
[`fd2bf48`](https://g
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221726236
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221724749
**[Test build #59301 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59301/consoleFull)**
for PR 13305 at commit
[`fd2bf48`](https://gi
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221726235
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221724543
@sureshthalamati Yeah you are right. Sorry for jumping the gun.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221724406
sure. I can add for EXTERNAL table also. Thank you for reviewing the PR,
Andrew.
---
If your project is set up for it, you can reply to this email and h
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13305#discussion_r64662860
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -292,10 +292,18 @@ case class TruncateTableCommand(
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221724081
add to whitelist
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13305#discussion_r64662799
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveCommandSuite.scala
---
@@ -345,6 +345,19 @@ class HiveCommandSuite extends Quer
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221723642
@sureshthalamati can you also add a case for EXTERNAL table? You can also
add `[SPARK-15536]` to the title
---
If your project is set up for it, you can reply to th
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13305#discussion_r64662478
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -292,10 +292,18 @@ case class TruncateTableCommand(
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13305#discussion_r64662387
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -292,10 +292,18 @@ case class TruncateTableCommand(
Github user sureshthalamati commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221722772
@hvanhovell
#13302 change does not seem to check for truncate table data source
table/view. It is throwing exception for table not found. The case I a
Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221719109
@sureshthalamati I think https://github.com/apache/spark/pull/13302 already
takes care of this.
---
If your project is set up for it, you can reply to this email an
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13305#issuecomment-221718036
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
GitHub user sureshthalamati opened a pull request:
https://github.com/apache/spark/pull/13305
[SPARK-15538][SQL] Adding error check for truncate table on a datasource
table or view.
## What changes were proposed in this pull request?
Adds check to throw error when user at
23 matches
Mail list logo
