[GitHub] spark pull request: [SPARK-15598] Change Aggregator.zero to Aggreg...

2016-05-26 Thread techaddict
Github user techaddict commented on the pull request: https://github.com/apache/spark/pull/13347#issuecomment-222048243 @rxin Yupp thats what I was about to ask, for calls where we just need `.zero` what do we do ? --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-15598] Change Aggregator.zero to Aggreg...

2016-05-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13347#issuecomment-222047757 **[Test build #59451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59451/consoleFull)** for PR 13347 at commit [`c278f44`](https://gi

[GitHub] spark pull request: [SPARK-15598] Change Aggregator.zero to Aggreg...

2016-05-26 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13347#issuecomment-222048050 Thanks for the pull request. But is the implementation corrct? I don't think you can just pass literal 1 into the init function. --- If your project is set up for it, yo

[GitHub] spark pull request: [SPARK-15598] Change Aggregator.zero to Aggreg...

2016-05-26 Thread techaddict
GitHub user techaddict opened a pull request: https://github.com/apache/spark/pull/13347 [SPARK-15598] Change Aggregator.zero to Aggregator.init ## What changes were proposed in this pull request? org.apache.spark.sql.expressions.Aggregator currently requires defining the zero v