[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/13370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/13370#issuecomment-222597634 Thanks - merging in master/2.0. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r65126050 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -204,8 +205,8 @@ class KeyValueGroupedDataset[K, V] private[sql](

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on the pull request: https://github.com/apache/spark/pull/13370#issuecomment-222595668 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r65125196 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/KeyValueGroupedDataset.scala --- @@ -204,8 +205,8 @@ class KeyValueGroupedDataset[K, V] private[sql]

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r65125156 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -132,6 +130,15 @@ class Column(protected[sql] val expr: Expression) extends Logg

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-30 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r65125096 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala --- @@ -132,6 +130,15 @@ class Column(protected[sql] val expr: Expression) extends Logg

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13370#issuecomment-93473 Test PASSed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/13370#issuecomment-93472 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13370#issuecomment-93443 **[Test build #59548 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59548/consoleFull)** for PR 13370 at commit [`36b804b`](https://g

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r64984155 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -41,15 +41,13 @@ import org.apache.spark.sql.catalyst.plans.logic

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r64983965 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala --- @@ -41,15 +41,13 @@ import org.apache.spark.sql.catalyst.plans.logical

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r64983961 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLContextSuite.scala --- @@ -24,6 +24,7 @@ import org.apache.spark.sql.catalyst.TableIdentifier imp

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r64983958 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileCatalogSuite.scala --- @@ -19,6 +19,8 @@ package org.apache.spark.sql.executio

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r64983960 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDDLCommandSuite.scala --- @@ -37,9 +35,9 @@ class HiveDDLCommandSuite extends PlanTest {

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/13370#discussion_r64983952 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala --- @@ -52,7 +52,7 @@ case class CatalogStorageFormat( o

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread rxin
GitHub user rxin opened a pull request: https://github.com/apache/spark/pull/13370 [SPARK-15638][SQL] Audit Dataset, SparkSession, and SQLContext ## What changes were proposed in this pull request? This patch contains a list of changes as a result of my auditing Dataset, SparkSe

[GitHub] spark pull request: [SPARK-15638][SQL] Audit Dataset, SparkSession...

2016-05-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/13370#issuecomment-89732 **[Test build #59548 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59548/consoleFull)** for PR 13370 at commit [`36b804b`](https://gi