Github user witgo closed the pull request at:
https://github.com/apache/spark/pull/1031
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57470785
OK so I was thinking about this some more and I'm not sure how much the
current change will help. @pwendell have you seen specific requests from other
users? If so
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57518693
I wrote a small test for this; it uses three implementations of the same
native library that print different things, and a small java class to call it.
This is the
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57572266
Ok, I'll try to use LD_LIBRARY_PATH.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57317439
I haven't looked at the code to fully understand what all changes would be
required and why its so much more complex. So if it makes the implementation
much simpler
Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57180050
sorry perhaps I'm missing something, why are we adding the value of
LD_LIBRARY_PATH to the java.library.path and not just using LD_LIBRARY_PATH
like proposed in the
Github user witgo commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57199913
The current solution is simple to implement.If we don't do so,we have to
change a lot of existing code.
---
If your project is set up for it, you can reply to this email
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57211561
Hey @tgravescs I actually don't mind capturing `LD_LIBRARY_PATH` and
inserting it into `java.library.path` - it has the same effect and it makes the
patch set much
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57051215
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20916/consoleFull)
for PR 1031 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57052882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57052879
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20916/consoleFull)
for PR 1031 at commit
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1031#discussion_r18118071
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -1466,6 +1471,25 @@ private[spark] object Utils extends Logging {
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-57030151
This LGTM (but there are merge conflicts again...)
@andrewor14 @pwendell could one of you guys take a look at this? Thanks!
---
If your project is set up for it,
Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-56412833
@witgo could you upmerge this please? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-56468425
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20681/consoleFull)
for PR 1031 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-56471518
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20681/
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-56471514
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20681/consoleFull)
for PR 1031 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-55082152
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20095/consoleFull)
for PR 1031 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1031#issuecomment-55087507
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20095/consoleFull)
for PR 1031 at commit
19 matches
Mail list logo
