Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-45067928
@mateiz , is it okay to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-45143083
Looks good! I've merged it into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-45011470
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-45011481
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-45016002
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-45016003
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15397/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-45024586
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-45024569
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-45028405
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15409/
---
If your project
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r13300795
--- Diff: python/pyspark/mllib/util.py ---
@@ -160,6 +157,40 @@ def saveAsLibSVMFile(data, dir):
lines.saveAsTextFile(dir)
+
Github user debasish83 commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-4487
sparse vector: (size,[i0,i1],[v0,v1])
This is not standard libsvm (glmnet-R, libsvm etc who expects libsvm input
won't work with this)...may be we can add a
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44885295
There is a `saveAsLibSVMFile` function in `MLUtils`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44885574
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44885557
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44890310
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15354/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44890309
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r13170960
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -180,7 +180,39 @@ object MLUtils {
}
/**
- * ::
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r13170957
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/util/MLUtils.scala ---
@@ -180,7 +180,39 @@ object MLUtils {
}
/**
- * ::
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r13171027
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -0,0 +1,121 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r13171126
--- Diff: python/pyspark/mllib/util.py ---
@@ -160,6 +157,40 @@ def saveAsLibSVMFile(data, dir):
lines.saveAsTextFile(dir)
+
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44500939
@mengxr made a few more small comments, but this looks good to merge once
those are fixed.
---
If your project is set up for it, you can reply to this email and have your
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44500971
BTW I also prefer the non-JSON format, it's a bit clearer and I don't think
there are huge benefits to JSON here.
---
If your project is set up for it, you can reply to
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44486347
Jenkins, test this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44486505
Build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44486510
Build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44490167
Build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-44490169
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15276/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43137270
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43196659
No opinion here on JSON -- whatever feels most standard. No worries on ST,
it is an implementation detail. I think its known quirks don't arise here.
---
If your project
GitHub user mengxr opened a pull request:
https://github.com/apache/spark/pull/685
[SPARK-1752][MLLIB] Standardize text format for vectors and labeled points
We should standardize the text format used to represent vectors and labeled
points. The proposed formats are the following:
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42501697
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43177180
Yes, it is unmaintained but it also means that it won't change in the
future, less likely than Guava. I'm actually okay to switch to JSON by
replacing `(` and `)` by `[`
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42489280
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43141642
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43140075
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42503646
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43171670
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43137287
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42499596
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42503648
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14796/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43140058
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43171674
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15013/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43145167
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43172284
@mengxr From those docs: StringTokenizer is a legacy class that is
retained for compatibility reasons although its use is discouraged in new
code. `Splitter` is not (only)
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43141646
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14993/
---
If your project is set up for it, you can
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42727421
I wrote a parser, which should be much faster than Scala's parser
combinators. For the schema, an alternative would be JSON. JSON doesn't
separate array from tuple. So we
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43141079
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43145168
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14995/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43168882
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43168891
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43117485
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43143520
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14994/
---
If your project is set up for it, you can
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43117500
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43124397
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14989/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43124396
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43143519
Merged build finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-43141068
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502571
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42492518
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502546
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42492519
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14788/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42501713
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12503350
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502576
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502581
--- Diff: python/pyspark/mllib/linalg.py ---
@@ -234,6 +233,45 @@ def dense(elements):
return array(elements, dtype=float64)
+
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42623397
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42503177
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14795/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42503175
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42489269
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42623389
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502539
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/LabeledPoint.scala ---
@@ -27,6 +28,28 @@ import org.apache.spark.mllib.linalg.Vector
*/
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502533
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -171,8 +192,11 @@ class SparseVector(
val indices: Array[Int],
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502535
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/LabeledPoint.scala ---
@@ -27,6 +28,28 @@ import org.apache.spark.mllib.linalg.Vector
*/
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502522
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -125,6 +127,25 @@ object Vectors {
}
/**
+ * Parses
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502558
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502554
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502540
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/LabeledPoint.scala ---
@@ -27,6 +28,28 @@ import org.apache.spark.mllib.linalg.Vector
*/
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/685#issuecomment-42625315
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502564
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502568
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -100,4 +100,27 @@ class VectorsSuite extends FunSuite {
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502569
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala ---
@@ -100,4 +100,27 @@ class VectorsSuite extends FunSuite {
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/685#discussion_r12502555
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/util/NumericParser.scala ---
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation
83 matches
Mail list logo
