Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12780712
--- Diff: bin/compute-classpath.cmd ---
@@ -42,6 +42,21 @@ if exist %FWDIR%RELEASE (
set CLASSPATH=%CLASSPATH%;%ASSEMBLY_JAR%
+rem When
Github user mateiz commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12782348
--- Diff: README.md ---
@@ -41,9 +42,9 @@ And run the following command, which should also return
1000:
Spark also comes with several sample programs in
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43474498
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43474514
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43474576
Thanks for the review, @andrewor14! I think I've dealt with all the
comments (modulo a few I replied to above). The enabledelayedexpansion thing
was very weird; if you
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43475552
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43475544
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43477472
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15077/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43477471
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43478312
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15078/
---
If your project
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43478310
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12807150
--- Diff: bin/compute-classpath.cmd ---
@@ -20,6 +20,13 @@ rem
rem This script computes Spark's classpath and prints it to stdout; it's
used by both
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12808084
--- Diff: bin/compute-classpath.cmd ---
@@ -20,6 +20,13 @@ rem
rem This script computes Spark's classpath and prints it to stdout; it's
used by both
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43550903
I tested this again on Windows building with and without hive and I can
verify that it works as we expect. I think this is ready to go.
---
If your project is set up
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43562033
@mateiz Is this good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43564080
@tdas sure, go for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43564151
Great! Thanks! Merging it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/819
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user mateiz opened a pull request:
https://github.com/apache/spark/pull/819
[SPARK-1876] Windows fixes to deal with latest distribution layout changes
- Look for JARs in the right place
- Launch examples the same way as on Unix
- Load datanucleus JARs if they exist
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43458281
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43458284
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43459321
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15072/
---
If your project
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12778830
--- Diff: bin/run-example ---
@@ -23,6 +23,16 @@ FWDIR=$(cd `dirname $0`/..; pwd)
export SPARK_HOME=$FWDIR
EXAMPLES_DIR=$FWDIR/examples
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12778833
--- Diff: bin/run-example ---
@@ -23,6 +23,16 @@ FWDIR=$(cd `dirname $0`/..; pwd)
export SPARK_HOME=$FWDIR
EXAMPLES_DIR=$FWDIR/examples
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12778836
--- Diff: bin/run-example2.cmd ---
@@ -30,7 +30,9 @@ if exist %FWDIR%conf\spark-env.cmd call
%FWDIR%conf\spark-env.cmd
rem Test that an argument
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12778839
--- Diff: bin/run-example2.cmd ---
@@ -30,7 +30,9 @@ if exist %FWDIR%conf\spark-env.cmd call
%FWDIR%conf\spark-env.cmd
rem Test that an argument
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12778945
--- Diff: bin/run-example ---
@@ -55,5 +54,5 @@ fi
./bin/spark-submit \
--master $EXAMPLE_MASTER \
--- End diff --
Not your change,
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12778951
--- Diff: bin/run-example2.cmd ---
@@ -47,15 +55,34 @@ if x%SPARK_EXAMPLES_JAR%==x (
goto exit
)
-rem Compute Spark classpath using
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12778956
--- Diff: bin/run-example2.cmd ---
@@ -30,7 +30,9 @@ if exist %FWDIR%conf\spark-env.cmd call
%FWDIR%conf\spark-env.cmd
rem Test that an argument
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/819#discussion_r12779005
--- Diff: README.md ---
@@ -41,9 +42,9 @@ And run the following command, which should also return
1000:
Spark also comes with several sample programs
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43467187
Did you mean to also remove the hive check here
https://github.com/apache/spark/blob/master/bin/compute-classpath.sh#L93?
---
If your project is set up for it, you
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43468247
Yes, I don't want to rely on jar being installed. It's not installed by
default when you grab a JRE (as far as I can tell). I'd like to eventually do
that on Unix too but
Github user mateiz commented on the pull request:
https://github.com/apache/spark/pull/819#issuecomment-43468276
My worry with Windows is people downloading pre-built Spark and getting a
bizarre behavior. I'm assuming most people will work with pre-built Spark
(since you'd mostly use
33 matches
Mail list logo
