Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46650188
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46650189
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15941/
---
If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46650243
Ok merging this in master branch-1.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1143
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/1143
[SPARK-2209][SQL] Cast shouldn't do null check twice.
Also took the chance to clean up cast a little bit. Too many arrows on each
line before!
You can merge this pull request into a Git repository
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46640185
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46640182
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46643096
All automated tests passed.
Refer to this link for build results:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/15937/
---
If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46643095
Merged build finished. All automated tests passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1143#discussion_r14006911
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -24,72 +24,89 @@ import
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1143#discussion_r14006923
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -24,72 +24,89 @@ import
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1143#discussion_r14007203
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -24,72 +24,89 @@ import
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1143#discussion_r14007430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -104,85 +121,118 @@ case class Cast(child: Expression,
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46646277
LGTM. Making everything other than `eval` to be `private[this]` makes
sense, so that `eval` is guaranteed to be the only entrance of type casting and
the null check
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1143#discussion_r14007468
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -104,85 +121,118 @@ case class Cast(child: Expression,
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/1143#discussion_r14007471
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -24,72 +24,89 @@ import org.apache.spark.sql.catalyst.types._
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46646557
Merged build started.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1143#issuecomment-46646550
Merged build triggered.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
18 matches
Mail list logo