[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-08-05 Thread YanTangZhai
Github user YanTangZhai closed the pull request at: https://github.com/apache/spark/pull/1392 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-08-05 Thread YanTangZhai
Github user YanTangZhai commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-51190110 @pwendell Sorry, I'm late. Please disregard this PR since #1734 has been closed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-08-05 Thread YanTangZhai
Github user YanTangZhai closed the pull request at: https://github.com/apache/spark/pull/1244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-30 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-50691533 @YanTangZhai can you merge this up to master and make sure it is passing tests? Thanks --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-21 Thread YanTangZhai
Github user YanTangZhai commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-49584362 Hi @andrewor14 , that's ok. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-17 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-49353609 Hey @YanTangZhai, on second thought I think we should keep the config, but not set it by default like we do currently. The user may have multiple installations of

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-16 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-49126716 We only want to do this if the driver shares the same directory structure as the executors. This is an assumption that is incorrect in many deployment settings.

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-16 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-49153988 @andrewor14 yeah, I agree with you, I just thought in somewhere (document in the earlier versions? I cannot find it now), the user has to set this env variable? so I

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-15 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-49122687 instead of discard sparkHome parameter entirely, shall we just prioritizing local SPARK_HOME env and pass the applicationDesc.sparkHome only if SPARK_HOME is not set

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-13 Thread YanTangZhai
GitHub user YanTangZhai opened a pull request: https://github.com/apache/spark/pull/1392 [SPARK-2290] Worker should directly use its own sparkHome instead of appDesc.sparkHome when LaunchExecutor Worker should directly use its own sparkHome instead of appDesc.sparkHome when

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-48839494 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-13 Thread YanTangZhai
Github user YanTangZhai commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-48839557 #1244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-13 Thread YanTangZhai
Github user YanTangZhai commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-48839668 fix #1244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-13 Thread YanTangZhai
Github user YanTangZhai commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48839912 I've fixed the compile problem. Please review and test again. Thanks very much. --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-13 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-48853888 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-48854002 QA tests have started for PR 1392. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16609/consoleFull ---

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-13 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1392#issuecomment-48855862 QA results for PR 1392:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-10 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48664105 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-10 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48664165 Changes look reasonable to me. There were a few questions from the mailing list about this, so it'll be good to get this in. --- If your project is set up for it,

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48664391 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48664408 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48664567 QA tests have started for PR 1244. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16518/consoleFull ---

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48672993 QA results for PR 1244:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds no public classesbrbrFor more information see test

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48673000 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16518/ --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-10 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48677179 @YanTangZhai This doesn't compile... could you fix it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48283271 LGTM pending tests, this is something that has confused people before, so I think it's best to just leave it out. --- If your project is set up for it, you can reply

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48283315 Jenkins, test this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48283504 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48298659 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48298667 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16401/ --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48419256 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48419483 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48419494 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48420065 Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16440/ --- If your project is set up for it, you can

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-07-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-48420063 Merged build finished. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-06-27 Thread YanTangZhai
GitHub user YanTangZhai opened a pull request: https://github.com/apache/spark/pull/1244 [SPARK-2290] Worker should directly use its own sparkHome instead of appDesc.sparkHome when LaunchExecutor Worker should directly use its own sparkHome instead of appDesc.sparkHome when

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-06-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-47317532 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2290] Worker should directly use its ow...

2014-06-27 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1244#issuecomment-47318509 If we are going to remove this feature, we should just take the sparkHome field out of `ApplicationDescription` entirely. --- If your project is set up for it, you