[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-03-19 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-83757019 I've spoken with @freeman-lab. I am going to send a new PR after replacing the algorithm to the new one and adding wrapper classes for ml package. --- If your project

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-03-19 Thread yu-iskw
Github user yu-iskw closed the pull request at: https://github.com/apache/spark/pull/2906 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-03-11 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-78214203 @freeman-lab, @srowen, I apologize for the delay in replying. I will modify the code ASAP. And I have a question about the implementation. I think this implementation

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-08 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22640591 --- Diff: data/mllib/sample_hierarchical_data.csv --- @@ -0,0 +1,150 @@ +5.1,3.5,1.4,0.2 --- End diff -- Good point =) Leave as is then.

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22640249 --- Diff: data/mllib/sample_hierarchical_data.csv --- @@ -0,0 +1,150 @@ +5.1,3.5,1.4,0.2 --- End diff -- Minor point - this wouldn't really be

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22641223 --- Diff: docs/mllib-clustering.md --- @@ -154,6 +156,175 @@ section of the Spark Quick Start guide. Be sure to also include *spark-mllib* to your build

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22641250 --- Diff: examples/src/main/java/org/apache/spark/examples/mllib/JavaHierarchicalClustering.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22641364 --- Diff: mllib/src/test/java/org/apache/spark/mllib/clustering/JavaHierarchicalClusteringSuite.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22641414 --- Diff: mllib/src/test/java/org/apache/spark/mllib/clustering/JavaHierarchicalClusteringSuite.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-08 Thread rnowling
Github user rnowling commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-69192847 @freeman-lab @srowen @mengxr many thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22633425 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22633847 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClusteringModel.scala --- @@ -0,0 +1,126 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22633951 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClusteringModel.scala --- @@ -0,0 +1,126 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22633997 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClusteringModel.scala --- @@ -0,0 +1,126 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22634802 --- Diff: examples/src/main/python/mllib/hierarchical_clustering.py --- @@ -0,0 +1,84 @@ +# +# Licensed to the Apache Software Foundation (ASF)

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-69134341 Hi @yu-iskw and @rnowling , I've spent time reviewing the code and using it in both Python and Scala. Overall great work, terrific to see my little gist turned into

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22635337 --- Diff: examples/src/main/python/mllib/hierarchical_clustering.py --- @@ -0,0 +1,84 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22634203 --- Diff: python/pyspark/mllib/clustering.py --- @@ -88,6 +92,162 @@ def train(cls, rdd, k, maxIterations=100, runs=1, initializationMode=k-means||

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22633758 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22633778 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22634674 --- Diff: docs/mllib-clustering.md --- @@ -154,6 +156,175 @@ section of the Spark Quick Start guide. Be sure to also include *spark-mllib* to your

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22634865 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22634887 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22634895 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22634890 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632101 --- Diff: data/mllib/sample_hierarchical_data.csv --- @@ -0,0 +1,150 @@ +5.1,3.5,1.4,0.2 --- End diff -- It might be nice if this could

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632146 --- Diff: examples/src/main/java/org/apache/spark/examples/mllib/JavaHierarchicalClustering.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632182 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClusteringModel.scala --- @@ -0,0 +1,126 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632172 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632194 --- Diff: mllib/src/test/scala/org/apache/spark/mllib/clustering/HierarchicalClusteringSuite.scala --- @@ -0,0 +1,330 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632220 --- Diff: examples/src/main/java/org/apache/spark/examples/mllib/JavaHierarchicalClustering.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632265 --- Diff: python/pyspark/mllib/clustering.py --- @@ -88,6 +92,162 @@ def train(cls, rdd, k, maxIterations=100, runs=1, initializationMode=k-means||

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632512 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632647 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632654 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632678 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632686 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClusteringModel.scala --- @@ -0,0 +1,126 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632804 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-07 Thread freeman-lab
Github user freeman-lab commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r22632919 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,627 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-06 Thread rnowling
Github user rnowling commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-68870971 Thanks @mengxr @freeman-lab! :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-05 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-68787775 @yu-iskw @rnowling, I asked @freeman-lab to make one pass on this PR. Let's ping him :) --- If your project is set up for it, you can reply to this email and have your

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-05 Thread freeman-lab
Github user freeman-lab commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-68794407 Hey all, thanks for the nudge =) I've been going through it, will get you feedback ASAP. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2015-01-05 Thread rnowling
Github user rnowling commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-68746596 @mengxr This PR has been lingering for a while. What can we do to get it a little more attention? Thanks! --- If your project is set up for it, you can reply to this

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62302445 There is a few conflicts with master brach. I will rebase my PR branch, and then force push it. --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62307500 [Test build #23121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23121/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62310159 [Test build #23121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23121/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62310162 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62323346 [Test build #23124 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23124/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62325994 [Test build #23124 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23124/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62325997 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62328415 [Test build #23125 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23125/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62332987 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62332985 [Test build #23125 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23125/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-09 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-6214 @srowen and @rnowling , Sorry for my complicated commits. I modified my source code. Could you review my PR? - I modified what you pointed out. - I

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62135443 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23052/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-07 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62147985 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23052/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-11-07 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-62147990 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-29 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r19535947 --- Diff: python/pyspark/mllib/clustering.py --- @@ -91,6 +99,58 @@ def train(cls, rdd, k, maxIterations=100, runs=1, initializationMode=k-means||

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-29 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60921575 @mengxr I added the performance test for vector's sparsity at Experiment 5: The Effects of Vector Sparsity. You can download a new result. Please check it.

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60921831 [Test build #22450 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22450/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60922006 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60922004 [Test build #22450 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22450/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-29 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60922265 @srowen I finished modifying the source code which you had pointed out. Can you review it ? --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60923278 [Test build #22451 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22451/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-29 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60931955 [Test build #22451 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22451/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-29 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60931967 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60566259 [Test build #22290 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22290/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60566367 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60566364 [Test build #22290 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22290/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread yu-iskw
Github user yu-iskw commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60566674 @mengxr thank you for your feedback. Is there a paper that you used as reference? If so, please cite it in the doc. Yes. I added the comment into the doc.

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60567740 [Test build #22291 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22291/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r19396451 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClusteringModel.scala --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r19396796 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,549 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r19396833 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,549 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r19396869 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,549 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread yu-iskw
Github user yu-iskw commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r19396916 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClustering.scala --- @@ -0,0 +1,549 @@ +/* + * Licensed to the Apache

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60575123 [Test build #22291 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22291/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-27 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60575130 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60542976 [Test build #22267 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22267/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60543195 [Test build #22268 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22268/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60544649 [Test build #22270 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22270/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60546522 [Test build #22268 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22268/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60546524 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60546587 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60546582 [Test build #22267 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22267/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60547114 [Test build #22270 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22270/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60547118 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-24 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60460281 Jenkins, add to whitelist. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-24 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60460354 ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60460562 [Test build #22177 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22177/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60460891 [Test build #22179 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22179/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60463499 [Test build #22177 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22177/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60463501 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-24 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60463744 @yu-iskw I added you to the whitelist. Future commits from you should trigger Jenkins automatically. Just took a very brief scan over the code and really appreciate the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60464011 [Test build #22179 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22179/consoleFull) for PR 2906 at commit

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60464016 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-23 Thread yu-iskw
GitHub user yu-iskw opened a pull request: https://github.com/apache/spark/pull/2906 [SPARK-2429] [MLlib] Hierarchical Implementation of KMeans I want to add a divisive hierarchical clustering algorithm implementation to MLlib. I don't support distance metrics other Euclidean

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-23 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2906#issuecomment-60214129 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-23 Thread rnowling
Github user rnowling commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r19267797 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/clustering/HierarchicalClusteringModel.scala --- @@ -0,0 +1,79 @@ +/* + * Licensed to the

[GitHub] spark pull request: [SPARK-2429] [MLlib] Hierarchical Implementati...

2014-10-23 Thread rnowling
Github user rnowling commented on a diff in the pull request: https://github.com/apache/spark/pull/2906#discussion_r19267891 --- Diff: python/pyspark/mllib/clustering.py --- @@ -91,6 +99,58 @@ def train(cls, rdd, k, maxIterations=100, runs=1, initializationMode=k-means||

  1   2   >