Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49760182
do you mind submitting a pep8 checker as part of Jenkins?
Will do. I won't be able to work on this today, but I will open a separate
PR for this this week
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49778872
A separate PR and JIRA would be better (since they are for different
things). Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49791186
I've created [SPARK-2627](https://issues.apache.org/jira/browse/SPARK-2627)
to track the Jenkins/CI part of this work. I'll post future updates there.
---
If your
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15197312
--- Diff: python/pyspark/statcounter.py ---
@@ -124,5 +125,5 @@ def sampleStdev(self):
return math.sqrt(self.sampleVariance())
def
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15197389
--- Diff: python/pyspark/statcounter.py ---
@@ -124,5 +125,5 @@ def sampleStdev(self):
return math.sqrt(self.sampleVariance())
def
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15197383
--- Diff: python/pyspark/statcounter.py ---
@@ -124,5 +125,5 @@ def sampleStdev(self):
return math.sqrt(self.sampleVariance())
def
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15197548
--- Diff: python/pyspark/shell.py ---
@@ -35,7 +35,8 @@
from pyspark.storagelevel import StorageLevel
# this is the equivalent of ADD_JARS
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15197618
--- Diff: python/pyspark/serializers.py ---
@@ -252,18 +251,20 @@ def load_stream(self, stream):
yield pair
def
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15197632
--- Diff: python/pyspark/serializers.py ---
@@ -229,8 +228,8 @@ def load_stream(self, stream):
yield pair
def __eq__(self,
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15197643
--- Diff: python/pyspark/serializers.py ---
@@ -197,8 +196,8 @@ def _load_stream_without_unbatching(self, stream):
return
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15197750
--- Diff: python/pyspark/context.py ---
@@ -192,15 +191,19 @@ def _ensure_initialized(cls, instance=None,
gateway=None):
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15197904
--- Diff: python/pyspark/cloudpickle.py ---
@@ -55,7 +55,7 @@
import dis
import traceback
-#relevant opcodes
+# relevant opcodes
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15198830
--- Diff: python/pyspark/cloudpickle.py ---
@@ -55,7 +55,7 @@
import dis
import traceback
-#relevant opcodes
+# relevant opcodes
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49671550
@davies PEP 8 recommends using [implied line continuation over
backslashes](http://legacy.python.org/dev/peps/pep-0008/#maximum-line-length)
where possible. It appears
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15200578
--- Diff: python/pyspark/cloudpickle.py ---
@@ -55,7 +55,7 @@
import dis
import traceback
-#relevant opcodes
+# relevant opcodes
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15200778
--- Diff: python/pyspark/cloudpickle.py ---
@@ -55,7 +55,7 @@
import dis
import traceback
-#relevant opcodes
+# relevant opcodes
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49674558
Parentheses or backslashes are welcome. We should just follow the hard
rules in PEP8, leave others open to contributors. Too strict rules may make
some people feel
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/1505#discussion_r15200865
--- Diff: python/pyspark/cloudpickle.py ---
@@ -55,7 +55,7 @@
import dis
import traceback
-#relevant opcodes
+# relevant opcodes
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49678538
OK, I've fixed the problems you pointed out, reverted the changes to
cloudpickle, and confirmed that `python/run-tests` passes.
---
If your project is set up for it,
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49685605
Thanks, LGTM.
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49689180
Reynold, is there anything else we need to clean up before we can have
`pep8` checks become part of the CI cycle?
Also, it sounds like we want to make an
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49694729
If we have fixed all the problems, let's do it. We should add pep8 check to
the Jenkins scripts (in /dev/).
I'm not 100% positive whether our Jenkins instances have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49694759
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49694764
Jenkins, add to whitelist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49694965
QA tests have started for PR 1505. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16941/consoleFull
---
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49698547
If we have to, we could probably somehow package `pep8` and its
dependencies as a standalone. It's doable but I think also a bit ugly and
harder to update.
As
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49698681
Let's definitely add the pep8 check in a separate PR. I'm waiting for
Jenkins to come back positive before merging this pull request.
I think it'd make sense to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49699504
QA results for PR 1505:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49699903
Merging this in master!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49699932
Now I've merged this, do you mind submitting a pep8 checker?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1505
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user nchammas opened a pull request:
https://github.com/apache/spark/pull/1505
[SPARK-2470] PEP8 fixes to PySpark
This pull request aims to resolve all outstanding PEP8 violations in
PySpark.
You can merge this pull request into a Git repository by running:
$ git pull
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49569809
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/1505#issuecomment-49572014
@davies can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
34 matches
Mail list logo
