Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1420#discussion_r20137843
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaUtils.scala
---
@@ -17,6 +17,7 @@
package
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1420#discussion_r20137858
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaUtils.scala
---
@@ -24,11 +25,12 @@ import java.lang.{Integer = JInt}
import
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62517611
Thank @Reinvigorate. @jerryshao Could you please delete that method, and
remove the ZKUtils import.
---
If your project is set up for it, you can reply to this email and
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62521177
[Test build #23214 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23214/consoleFull)
for PR 1420 at commit
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62521930
Thanks @tdas and @Reinvigorate , I've removed this method as you suggested,
please help to review :)
---
If your project is set up for it, you can reply to this email
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62522174
LGTM. Will merge when tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62527276
KafkaStreamSuite has passed. So I am merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62530223
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62530215
[Test build #23214 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23214/consoleFull)
for PR 1420 at commit
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/1420
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62497136
Could you merge conflicts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/1420#discussion_r20130949
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaUtils.scala
---
@@ -151,4 +153,23 @@ object KafkaUtils {
createStream[K,
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/1420#discussion_r20131759
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaUtils.scala
---
@@ -151,4 +153,23 @@ object KafkaUtils {
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62505198
[Test build #23199 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23199/consoleFull)
for PR 1420 at commit
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62505434
Hi TD, I've rebased the code to the latest master. I agree with you that
providing this utility function for Kafka in Spark Streaming is quite strange,
IMO we can just
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62505592
[Test build #23199 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23199/consoleFull)
for PR 1420 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62505595
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62505927
Jenkins, retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62506160
[Test build #23201 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23201/consoleFull)
for PR 1420 at commit
Github user Reinvigorate commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62506418
what is your opinion?
@jerryshao Yeah I think @tdas is spot on.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62506569
[Test build #23201 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23201/consoleFull)
for PR 1420 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62506570
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62506807
Quite strange Jenkins fails to build this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62507786
[Test build #23203 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23203/consoleFull)
for PR 1420 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62513479
[Test build #23203 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23203/consoleFull)
for PR 1420 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-62513486
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user Reinvigorate commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-5874
@tdas This would bring the kafka receiver in alignment with kafka 0.8. If
folks would like the old kafka 0.7 behavior resetOffset does the trick. It
looks like
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-58733449
@Reinvigorate Thanks for your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jerryshao commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-52269406
Hi @tdas , would you mind taking a look at this? thanks a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-49975753
QA tests have started for PR 1420. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17109/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-49979126
QA results for PR 1420:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-49962076
QA tests have started for PR 1420. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17088/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-49964101
QA results for PR 1420:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/1420
[SPARK-2492][Streaming] kafkaReceiver minor changes to align with Kafka 0.8
Update the KafkaReceiver's behavior when auto.offset.reset is set to
smallest, which is aligned with Kafka 0.8
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-49032122
QA tests have started for PR 1420. This patch merges cleanly. brView
progress:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16675/consoleFull
---
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/1420#issuecomment-49046694
QA results for PR 1420:br- This patch PASSES unit tests.br- This patch
merges cleanlybr- This patch adds no public classesbrbrFor more
information see test
36 matches
Mail list logo
