[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2015-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1480 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2015-01-19 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/1480#issuecomment-70577766 Let's close this issue pending an update from @watermen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2015-01-05 Thread tnachen
Github user tnachen commented on the pull request: https://github.com/apache/spark/pull/1480#issuecomment-68792088 @watermen Can you update the patch as @andrewor14 mentioned? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2014-09-11 Thread andrewor14
Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/1480#issuecomment-55338293 @watermen A recently merged PR may be relevant to your patch: #2138. Since both coarse-grained and fine-grained executors now cleans up its environment in

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2014-09-05 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1480#issuecomment-54694581 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2014-07-29 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1480#issuecomment-50442106 But why is that? The JVM should always call shutdown hooks when it exists. Is Mesos killing the process? I'm curious because we might have other behavior that

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2014-07-28 Thread watermen
Github user watermen commented on the pull request: https://github.com/apache/spark/pull/1480#issuecomment-50426714 @mateiz Without this, the DiskStore's shutdown hook is only called when spark on Standalone Mode. When running spark over Mesos in “fine-grained” modes or

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2014-07-27 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1480#issuecomment-50289129 Can you explain what happens without this? I thought the DiskStore's shutdown hook is still called when the executor exits, so it will still clean up blocks. --- If

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2014-07-27 Thread mateiz
Github user mateiz commented on the pull request: https://github.com/apache/spark/pull/1480#issuecomment-50289133 Jenkins, test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2014-07-18 Thread watermen
GitHub user watermen opened a pull request: https://github.com/apache/spark/pull/1480 [SPARK-2572] Delete the local dir on executor automatically when using spark on Mesos. When running spark over Mesos in “fine-grained” modes or “coarse-grained” mode. After the

[GitHub] spark pull request: [SPARK-2572] Delete the local dir on executor ...

2014-07-18 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/1480#issuecomment-49405622 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your