[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/1570 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-25 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-50121775 Thanks! I've merge this into master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread chenghao-intel
GitHub user chenghao-intel opened a pull request: https://github.com/apache/spark/pull/1570 [SPARK-2665] [SQL] Add EqualNS Unit Tests Hive Supports the operator =, which returns same result with EQUAL(=) operator for non-null operands, but returns TRUE if both are NULL, FALSE if

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49979539 This is really nice - passes a lot more tests. I guess we will eventually run into the problem that the unit tests without parallelization will take too long... --- If

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49979557 Do you mind looking into how we can parallelize the hive compatibility tests? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49979649 QA tests have started for PR 1570. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17113/consoleFull ---

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49979808 Yes, I will think about how to parallelize those tests. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49980288 There is already support for [running the hive tests in

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49980451 Does our CI script use it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49980626 Yup! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread chenghao-intel
Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/1570#discussion_r15335466 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala --- @@ -236,6 +236,8 @@ trait HiveTypeCoercion {

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49982270 QA tests have started for PR 1570. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17116/consoleFull ---

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread adrian-wang
Github user adrian-wang commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49982658 I think you forgot to white-list the test:) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49983074 Yes, thank you very much. Added :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49983324 QA tests have started for PR 1570. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17117/consoleFull ---

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49989064 QA results for PR 1570:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brcase class

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49991475 QA results for PR 1570:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brcase class

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-49992124 QA results for PR 1570:br- This patch FAILED unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brcase class

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-50054494 `orc_predicate_pushdown` looks like a poorly written test to me. Both of the results returned satisfy the predicate. Really you should never have a limit clause

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread chenghao-intel
Github user chenghao-intel commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-50097282 Thank you @marmbrus , it's done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-50097380 QA tests have started for PR 1570. This patch merges cleanly. brView progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17149/consoleFull ---

[GitHub] spark pull request: [SPARK-2665] [SQL] Add EqualNS Unit Tests

2014-07-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/1570#issuecomment-50102831 QA results for PR 1570:br- This patch PASSES unit tests.br- This patch merges cleanlybr- This patch adds the following public classes (experimental):brcase class