[GitHub] spark pull request: [SPARK-3065][SQL] Timestamp support in the par...

2014-08-25 Thread chutium
Github user chutium commented on the pull request: https://github.com/apache/spark/pull/2084#issuecomment-53243726 is this PR for SPARK-3065 or SPARK-3173 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] spark pull request: [SPARK-3065][SQL] Timestamp support in the par...

2014-08-25 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2084#issuecomment-53358858 Thanks for working on this! Can you modify the PR title to point to SPARK-3173 instead? Also please add a test case in SQLQuerySuite. @chuxi I believe

[GitHub] spark pull request: [SPARK-3065][SQL] Timestamp support in the par...

2014-08-24 Thread chuxi
Github user chuxi commented on the pull request: https://github.com/apache/spark/pull/2084#issuecomment-53189498 I think CAST is the better choice(Compared with the NO CAST method). It is implemented in the case class Cast(child: Expression, dataType: DataType) extends

[GitHub] spark pull request: [SPARK-3065][SQL] Timestamp support in the par...

2014-08-22 Thread byF
Github user byF commented on a diff in the pull request: https://github.com/apache/spark/pull/2084#discussion_r16586456 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala --- @@ -357,7 +358,7 @@ class SqlParser extends StandardTokenParsers with

[GitHub] spark pull request: [SPARK-3065][SQL] Timestamp support in the par...

2014-08-21 Thread byF
GitHub user byF opened a pull request: https://github.com/apache/spark/pull/2084 [SPARK-3065][SQL] Timestamp support in the parser If you have a table with TIMESTAMP column, that column can't be used in WHERE clause properly - it is not evaluated properly.

[GitHub] spark pull request: [SPARK-3065][SQL] Timestamp support in the par...

2014-08-21 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2084#issuecomment-52952258 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3065][SQL] Timestamp support in the par...

2014-08-21 Thread chuxi
Github user chuxi commented on a diff in the pull request: https://github.com/apache/spark/pull/2084#discussion_r16580536 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala --- @@ -357,7 +358,7 @@ class SqlParser extends StandardTokenParsers with