Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2341#discussion_r17509255
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -120,81 +114,35 @@ class DecisionTree (private val strategy: Strategy)
Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/2341#discussion_r17509172
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -87,17 +87,11 @@ class DecisionTree (private val strategy: Strategy)
e
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2341
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/2341#issuecomment-55375636
LGTM except minor inline comments. I'm merging this in and could you make
the changes with your next update? Thanks!
---
If your project is set up for it, you can reply t
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2341#discussion_r17466108
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -435,18 +385,18 @@ object DecisionTree extends Serializable with Logging
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2341#discussion_r17466105
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -120,81 +114,35 @@ class DecisionTree (private val strategy: Strategy)
ex
Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/2341#discussion_r17465271
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -87,17 +87,11 @@ class DecisionTree (private val strategy: Strategy)
exte
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2341#issuecomment-55355197
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/76/consoleFull)
for PR 2341 at commit
[`07dd1ee`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2341#issuecomment-55351994
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/76/consoleFull)
for PR 2341 at commit
[`07dd1ee`](https://github.com/ap
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/2341#issuecomment-55351898
I just pushed 2 small (but important) bug fixes onto this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
10 matches
Mail list logo
