[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread BigCrunsh
GitHub user BigCrunsh opened a pull request: https://github.com/apache/spark/pull/2398 [SPARK-3396][MLLIB] Use SquaredL2Updater in LogisticRegressionWithSGD SimpleUpdater ignores the regularizer, which leads to an unregularized LogReg. To enable the common L2 regularizer (and

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-55594378 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20337/consoleFull) for PR 2231 at commit

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread BigCrunsh
Github user BigCrunsh closed the pull request at: https://github.com/apache/spark/pull/2231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-55594501 Changed target to master (https://github.com/apache/spark/pull/2398) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2398#issuecomment-55595028 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20338/consoleFull) for PR 2398 at commit

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2398#issuecomment-55604710 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20338/consoleFull) for PR 2398 at commit

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2398#issuecomment-55680373 LGTM. Merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2398 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-55376180 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-55376727 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20223/consoleFull) for PR 2231 at commit

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-55384423 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20223/consoleFull) for PR 2231 at commit

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-12 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-55428631 @BigCrunsh Just saw that the target is `branch-1.0`. Could you change the target to `master`? Usually we first apply the patch to master and then backport it to old

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-04 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54459193 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-04 Thread BigCrunsh
Github user BigCrunsh commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54459168 @mengxr: done ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54460133 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19783/consoleFull) for PR 2231 at commit

[GitHub] spark pull request: [SPARK-3396][MLLIB] Use SquaredL2Updater in Lo...

2014-09-04 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2231#issuecomment-54473057 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/19783/consoleFull) for PR 2231 at commit