Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r18078535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -96,21 +103,69 @@ abstract class LogicalPlan ext
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r18066083
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -96,21 +103,69 @@ abstract class LogicalPlan exte
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r18065885
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -96,21 +103,69 @@ abstract class LogicalPlan exte
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r18017841
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -96,21 +103,69 @@ abstract class LogicalPlan ext
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2382
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-56120103
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20557/consoleFull)
for PR 2382 at commit
[`01cc29a`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-56119800
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20559/consoleFull)
for PR 2382 at commit
[`c21171e`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-56115851
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20559/consoleFull)
for PR 2382 at commit
[`c21171e`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-56115401
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20557/consoleFull)
for PR 2382 at commit
[`01cc29a`](https://github.com/ap
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55840530
Oh, one more thing, please help rename this test case:
https://github.com/apache/spark/blob/0a7091e689a4c8b1e7b61e9f0873e6557f40d952/sql/hive/src/test/scala/org/apache/s
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17622161
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveResolutionSuite.scala
---
@@ -57,13 +57,14 @@ class HiveResolutionSuite extends Hi
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17622093
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveResolutionSuite.scala
---
@@ -57,13 +57,14 @@ class HiveResolutionSuite extends H
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17620503
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -98,12 +98,12 @@ case class Star(
override def w
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17620453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/package.scala
---
@@ -22,4 +22,9 @@ package org.apache.spark.sql.catalyst
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17620241
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveResolutionSuite.scala
---
@@ -57,13 +57,14 @@ class HiveResolutionSuite extends Hi
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55685249
LGTM except some minor issues mentioned in the comments :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17579912
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveResolutionSuite.scala
---
@@ -57,13 +57,14 @@ class HiveResolutionSuite extends H
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17578483
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/package.scala
---
@@ -22,4 +22,9 @@ package org.apache.spark.sql.catalyst
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17578267
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveResolutionSuite.scala
---
@@ -57,13 +57,14 @@ class HiveResolutionSuite extends H
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17578145
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -96,8 +101,17 @@ abstract class LogicalPlan exte
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17531262
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
---
@@ -105,7 +119,9 @@ abstract class LogicalPlan
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17531193
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/package.scala
---
@@ -22,4 +22,9 @@ package org.apache.spark.sql.catalyst
Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2382#discussion_r17531198
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
@@ -98,12 +98,12 @@ case class Star(
override
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55507264
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20276/consoleFull)
for PR 2382 at commit
[`219805a`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55507198
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/89/consoleFull)
for PR 2382 at commit
[`5b93711`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55504315
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20276/consoleFull)
for PR 2382 at commit
[`219805a`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55504293
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/89/consoleFull)
for PR 2382 at commit
[`5b93711`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55504038
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20275/consoleFull)
for PR 2382 at commit
[`5b93711`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55504003
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20275/consoleFull)
for PR 2382 at commit
[`5b93711`](https://github.com/ap
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55503990
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/88/consoleFull)
for PR 2382 at commit
[`c2f2ec8`](https://github.com/a
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55503955
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/88/consoleFull)
for PR 2382 at commit
[`c2f2ec8`](https://github.com/ap
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55503862
/cc @ericl
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2382#issuecomment-55503844
/cc @liancheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user marmbrus opened a pull request:
https://github.com/apache/spark/pull/2382
[SPARK-3414][SQL] Replace LowerCaseSchema with Resolver
_This PR is a follow up to #2293 (and to a lesser extent #2262 #2334)._
In #2293 the catalog was changed to store analyzed logical pl
34 matches
Mail list logo
