Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2404#issuecomment-55757044
It happens because in the git diff the script compares the PR branch with
master and if PR is not rebased to the tip of master. False reporting will
happen.
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2404#issuecomment-55759519
Actually, I guess if a class was removed from master but not also removed
from the PR fork, then that would show up as an added class.
---
If your project is set up
GitHub user rxin opened a pull request:
https://github.com/apache/spark/pull/2404
[SPARK-3540] Add reboot-slaves functionality to the ec2 script
Tested on a real cluster.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rxin/spark
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2404#issuecomment-55687301
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20364/consoleFull)
for PR 2404 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2404#issuecomment-55690973
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/20364/consoleFull)
for PR 2404 at commit
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/2404#issuecomment-55691649
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2404#issuecomment-55692669
Merging in master. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/2404#issuecomment-55692659
@ScrapCodes any idea why random public classes are being reported, even
though they have nothing to do with this PR?
---
If your project is set up for it, you can reply to
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2404
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/2404#issuecomment-55693199
It happens because in the git diff the script compares the PR branch with
master and if PR is not rebased to the tip of master. False reporting will
happen.
---
If
Github user ScrapCodes commented on the pull request:
https://github.com/apache/spark/pull/2404#issuecomment-55693512
So I guess it came from the commit,
https://github.com/apache/spark/commit/da33acb8b681eca5e787d546fe922af76a151398.
But this seems to be present in your branch. So
11 matches
Mail list logo
