Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/9767
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-161240003
merged to master / 1.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-161203603
Yeah I think it's fine to pull in - but do it quickly because an RC will go
out very soon!
---
If your project is set up for it, you can reply to this email and have
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-160908727
Pinging @JoshRosen @pwendell for an opinion on slipping this into 1.6. I'm
still inclined to put it in but I'm aware this week there's a more conservative
stance on 1.6.
Github user schot commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-160271652
@srowen @JoshRosen PR has been rebased to resolve the conflict on
MimaExcludes.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-160271315
@schot this'll need a rebase. @JoshRosen are you OK with this for 1.6?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user schot commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-159591402
Because I merged the fix in the previous commit Jenkins retest does not
happen automatically?
---
If your project is set up for it, you can reply to this email and have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-159592131
**[Test build #2111 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2111/consoleFull)**
for PR 9767 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-159617839
**[Test build #2111 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2111/consoleFull)**
for PR 9767 at commit
Github user schot commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-158928365
@srowen Yes, I added a Mima exclude.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-158887770
@schot I think you will have to add the MiMa exclude that the error message
in the output mentions. It's a 'false positive' but MiMa needs to be reassured.
---
If your
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-158652339
**[Test build #2094 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2094/consoleFull)**
for PR 9767 at commit
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-158650446
I think this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-158650509
**[Test build #2094 has
started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2094/consoleFull)**
for PR 9767 at commit
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-157833353
Yeah, AFAIK you only need to add it to the traint.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9767#discussion_r45247411
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala
---
@@ -62,6 +62,9 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]]
extends
Github user schot commented on a diff in the pull request:
https://github.com/apache/spark/pull/9767#discussion_r45254169
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala
---
@@ -62,6 +62,9 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]]
extends
Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/9767#discussion_r45255992
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala
---
@@ -62,6 +62,9 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]]
extends
Github user schot commented on a diff in the pull request:
https://github.com/apache/spark/pull/9767#discussion_r45257971
--- Diff: core/src/main/scala/org/apache/spark/api/java/JavaRDDLike.scala
---
@@ -62,6 +62,9 @@ trait JavaRDDLike[T, This <: JavaRDDLike[T, This]]
extends
Github user schot commented on the pull request:
https://github.com/apache/spark/pull/9767#issuecomment-157503489
If I understand the discussion in SPARK-3266 correctly the method should
only be added to the JavaRRDLike trait and not the abstract class.
I have updated the PR
20 matches
Mail list logo
