[GitHub] spark pull request: [SPARK-3580] Add Consistent Method To Get Numb...

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-157353135 Yes, ideally. @JoshRosen am I right that we have to add the new method to the `JavaRDDLike` trait or the abstract class that implements it in order to avoid binary

[GitHub] spark pull request: [SPARK-3580] Add Consistent Method To Get Numb...

2015-11-17 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-157335532 This is such a noisy change for really little gain that I don't think it's worth it. At best just ensure there is a getNumPartitions in each language. --- If your

[GitHub] spark pull request: [SPARK-3580] Add Consistent Method To Get Numb...

2015-11-17 Thread schot
Github user schot commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-157352481 Although it would be nice to fix the inconsistencies in the usage of partitions.length vs partitions.size, I agree that its better to stick to just adding

[GitHub] spark pull request: [SPARK-3580] Add Consistent Method To Get Numb...

2015-11-17 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/9767#issuecomment-157327010 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-3580] Add Consistent Method To Get Numb...

2015-11-17 Thread schot
GitHub user schot opened a pull request: https://github.com/apache/spark/pull/9767 [SPARK-3580] Add Consistent Method To Get Number of RDD Partitions Across Different Languages I have tried to address all the comments in pull request https://github.com/apache/spark/pull/2447.