[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-59551302 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/396/consoleFull) for PR 2717 at commit

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-17 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-59562802 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/396/consoleFull) for PR 2717 at commit

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-17 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-59576898 I'd like to pull this in - is that alright @marmbrus? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-17 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-59576965 Yes, please do. On Oct 17, 2014 5:10 PM, Patrick Wendell notificati...@github.com wrote: I'd like to pull this in - is that alright @marmbrus

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2717 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-13 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58952603 Jenkins - retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-13 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58954317 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58709224 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21599/consoleFull) for PR 2717 at commit

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58709232 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-10 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58710443 @marmbrus LGTM, just wonder that why you do not use IntegerType as returnType in the tests? (no change needed) --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-10 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58712206 @davies, I was lazy and didn't want to look up the syntax for that :P You are right its a little weird, but Hive supports it. --- If your project is set up for

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-10 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58729663 Jenkins, retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58729910 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21609/consoleFull) for PR 2717 at commit

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58733106 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21609/consoleFull) for PR 2717 at commit

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58733110 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58574660 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21549/consoleFull) for PR 2717 at commit

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-09 Thread davies
Github user davies commented on a diff in the pull request: https://github.com/apache/spark/pull/2717#discussion_r18687839 --- Diff: python/pyspark/tests.py --- @@ -679,6 +679,12 @@ def test_udf(self): [row] = self.sqlCtx.sql(SELECT twoArgs('test', 1)).collect()

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-08 Thread marmbrus
GitHub user marmbrus opened a pull request: https://github.com/apache/spark/pull/2717 [SPARK-3855][SQL] Preserve the result attribute of python UDFs though transformations In the current implementation it was possible for the reference to change after analysis. You can merge this

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58431697 [QA tests have started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21485/consoleFull) for PR 2717 at commit

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-08 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58436504 It's reproducable by this query: ``` SELECT strlen(a) FROM test WHERE strlen(a) 1 ``` --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-08 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58437456 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-08 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58437446 [QA tests have finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/21485/consoleFull) for PR 2717 at commit

[GitHub] spark pull request: [SPARK-3855][SQL] Preserve the result attribut...

2014-10-08 Thread davies
Github user davies commented on the pull request: https://github.com/apache/spark/pull/2717#issuecomment-58438988 @marmbrus Could you add a test in pyhon/pyspark/tests.py (SQLTests) ? --- If your project is set up for it, you can reply to this email and have your reply appear on