Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-61385447
Thanks! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2887
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19662265
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -223,21 +223,23 @@ class HiveContext(sc: SparkContext) extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-61327098
[Test build #22638 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22638/consoleFull)
for PR 2887 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-61334242
[Test build #22638 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22638/consoleFull)
for PR 2887 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-61334248
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-61344283
@marmbrus This should be ready to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user scwf commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19701171
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,6 +296,14 @@ class HiveContext(sc: SparkContext) extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19701845
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,6 +296,14 @@ class HiveContext(sc: SparkContext) extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19456785
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -223,21 +223,23 @@ class HiveContext(sc: SparkContext) extends
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60723293
Hey @zhzhan, left some comments both here and in [your
PR](https://github.com/apache/spark/pull/2967#discussion_r19457392).
Considering all the reasons I mentioned in
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60735084
[Test build #22357 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22357/consoleFull)
for PR 2887 at commit
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19462828
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60738690
[Test build #22357 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22357/consoleFull)
for PR 2887 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60738695
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60756867
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60759465
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60760546
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60760984
[Test build #22361 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22361/consoleFull)
for PR 2887 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60766956
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60766941
[Test build #22361 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22361/consoleFull)
for PR 2887 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60779134
According to the line number information in the Hive failure output, the
test was executed against Hive 0.13.1, while the assembly was built with
`-Phive-0.12.0`.
Github user zhzhan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19482722
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user zhzhan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19482843
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -223,21 +223,23 @@ class HiveContext(sc: SparkContext) extends
Github user zhzhan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19483002
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user zhzhan commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60786220
@liancheng The test failure may be caused by
SessionState.start(sessionState) with the same sessionState multiple times. If
SessionState.get is called to decide whether
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19486333
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19486625
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user zhzhan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19487146
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19488002
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user zhzhan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19488429
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19488530
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19489429
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user zhzhan commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60808752
@liancheng With the check if (SessionState.get() != sessionState),
./sbt/sbt -Phadoop-2.3 -Phive hive/test-only *.HiveCompatibilitySuite -- -z
groupby1 is running OK.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60848939
[Test build #22393 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22393/consoleFull)
for PR 2887 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60849470
@zhzhan Building assembly jar with `-Phive-0.12.0` but run tests without it
is introduced in
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19511501
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -288,8 +296,15 @@ class HiveContext(sc: SparkContext) extends
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60850603
[Test build #22395 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22395/consoleFull)
for PR 2887 at commit
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60851073
@marmbrus This should be ready to go once Jenkins nods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19513208
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -223,21 +223,23 @@ class HiveContext(sc: SparkContext) extends
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60854327
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60854325
[Test build #22393 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22393/consoleFull)
for PR 2887 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60855893
[Test build #22395 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22395/consoleFull)
for PR 2887 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60855899
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60865171
Okay, I tested this manually with a SHOW TABLES on a fresh context and it
seems to init correctly. Merging this to master. Thanks!
---
If your project is set up for
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60865295
Actually... sorry going to wait for the hive 13 thrift server PR so that we
run tests on the server as a sanity check.
---
If your project is set up for it, you can
Github user zhzhan commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60683244
@liancheng I send a PR https://github.com/apache/spark/pull/2967 against
similar issue. Please take a look. If you think it is duplicated with this one,
please let me
Github user zhzhan commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19443373
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
@@ -223,21 +223,23 @@ class HiveContext(sc: SparkContext) extends
Github user zhzhan commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60684050
@liancheng I send a PR #2967 against similar issue. Please take a look. My
major concern is that the SessionState.start(state) may be invoked multiple
times. If you
Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60512447
Sure, will rebase this PR to fix that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zhzhan commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60445711
@liancheng I was just aware of this issue. In the commit this morning
#2241, I have following change in HiveContext.scala, because I didn't realize
that the state has
Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/2887#discussion_r19261442
--- Diff:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suite.scala
---
@@ -150,10 +150,12 @@ class
GitHub user liancheng opened a pull request:
https://github.com/apache/spark/pull/2887
[SPARK-4037][SQL] Removes the SessionState instance created in
HiveThriftServer2
`HiveThriftServer2` creates a global singleton `SessionState` instance and
overrides `HiveContext` to inject the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60043829
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22024/consoleFull)
for PR 2887 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60046864
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60046859
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22024/consoleFull)
for PR 2887 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60051452
[QA tests have
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22032/consoleFull)
for PR 2887 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60058036
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2887#issuecomment-60058029
[QA tests have
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22032/consoleFull)
for PR 2887 at commit
59 matches
Mail list logo
