[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60516815 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60516907 [Test build #22243 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22243/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60517727 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60517725 [Test build #22243 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22243/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60518095 [Test build #22245 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22245/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60518982 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60518980 [Test build #22245 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22245/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread JoshRosen
Github user JoshRosen commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60524502 It looks like the build configuration for the thriftserver tests may be broken, which is why they're failing: ``` [error] Expected ID character [error]

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60528480 Thanks, I'll try to create another branch from master and then push. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread sarutak
GitHub user sarutak opened a pull request: https://github.com/apache/spark/pull/2946 [SPARK-4061][SQL] We cannot use EOL character in the operand of LIKE predicate. We cannot use EOL character like \n or \r in the operand of LIKE predicate. So following condition is never true.

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2946#issuecomment-60528637 This PR is mirror of #2908. Build configuration in #2908 may be broken so trying to create another branch. --- If your project is set up for it, you can reply to

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2946#issuecomment-60528883 [Test build #22250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22250/consoleFull) for PR 2946 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2946#issuecomment-60529062 [Test build #22250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22250/consoleFull) for PR 2946 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2946#issuecomment-60529064 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2946#issuecomment-60529394 [Test build #22251 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22251/consoleFull) for PR 2946 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2946#issuecomment-60530531 [Test build #22251 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22251/consoleFull) for PR 2946 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2946#issuecomment-60530534 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread sarutak
Github user sarutak closed the pull request at: https://github.com/apache/spark/pull/2946 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60531675 [Test build #22254 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22254/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60532846 [Test build #22254 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22254/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60532848 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60533145 [Test build #453 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/453/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60533477 Ah, I see. It's related to #2950. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60533825 [Test build #22260 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22260/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60534345 [Test build #453 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/453/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60535218 [Test build #464 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/464/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60536953 [Test build #22260 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22260/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60536955 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60537003 [Test build #464 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/464/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread marmbrus
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60538119 Thanks for working on this! Merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/2908 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60475008 [Test build #22205 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22205/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60475797 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60475796 [Test build #22205 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22205/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-25 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60476202 retest this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60476285 [Test build #22214 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22214/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-25 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60476952 [Test build #22214 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22214/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-25 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60476953 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread sarutak
Github user sarutak commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60349437 Thanks @liancheng ! I've refactored and added test cases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60349557 [Test build #22121 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22121/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60351481 [Test build #22121 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22121/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60351486 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60353571 [Test build #22130 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22130/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60357849 [Test build #22130 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22130/consoleFull) for PR 2908 at commit

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60357855 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2908#discussion_r19327703 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -102,31 +102,27 @@ case class Like(left:

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2908#discussion_r19327725 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -102,31 +102,27 @@ case class Like(left:

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2908#discussion_r19327837 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -102,31 +102,27 @@ case class Like(left:

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2908#discussion_r19328214 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -102,31 +102,27 @@ case class Like(left:

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2908#discussion_r19328236 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -102,31 +102,27 @@ case class Like(left:

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread sarutak
Github user sarutak commented on a diff in the pull request: https://github.com/apache/spark/pull/2908#discussion_r19328446 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -102,31 +102,27 @@ case class Like(left:

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-24 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60361563 LGTM, thanks for fixing this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-23 Thread liancheng
Github user liancheng commented on the pull request: https://github.com/apache/spark/pull/2908#issuecomment-60256774 Good catch! Would you mind to add a unit test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] spark pull request: [SPARK-4061][SQL] We cannot use EOL character ...

2014-10-23 Thread liancheng
Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/2908#discussion_r19284542 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala --- @@ -103,21 +103,21 @@ case class Like(left: