Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64305529
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -199,20 +200,123 @@ class AstBuilder extends
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64305522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -199,20 +200,123 @@ class AstBuilder extends
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r6430
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoDir.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64305535
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -199,20 +200,123 @@ class AstBuilder extends
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64305516
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -50,6 +50,10 @@ private[hive] trait HiveStrategies {
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64305196
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -374,6 +375,17 @@ case class
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64304947
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -198,6 +198,7 @@ query
insertInto
:
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64304954
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -374,6 +375,17 @@ case class
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64304944
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -713,6 +714,7 @@ WITH: 'WITH';
VALUES: 'VALUES';
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64172295
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoDir.scala
---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64172241
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -199,20 +200,123 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64172078
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -199,20 +200,123 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64172019
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
---
@@ -199,20 +200,123 @@ class AstBuilder extends
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64171963
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -50,6 +50,10 @@ private[hive] trait HiveStrategies {
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64171948
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -374,6 +375,17 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64171821
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -374,6 +375,17 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64171525
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -198,6 +198,7 @@ query
insertInto
: INSERT
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r64171510
--- Diff:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4 ---
@@ -713,6 +714,7 @@ WITH: 'WITH';
VALUES: 'VALUES';
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/spark/pull/13067#issuecomment-220663015
@hvanhovell @rxin can one of you review this PR. I was hoping to get it in
the 2.0 branch if its not too late.
---
If your project is set up for it, you can
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13067#issuecomment-219894120
Please let me cc @hvanhovell because it seems most of codes were recently
updated by him.
---
If your project is set up for it, you can reply to this email and
Github user prongs commented on the pull request:
https://github.com/apache/spark/pull/13067#issuecomment-219742726
Any update on this? Seems like a useful feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/spark/pull/13067#issuecomment-218882938
@HyukjinKwon fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13067#issuecomment-218871601
@Parth-Brahmbhatt I think the title of this PR, `[SPARK-4131] [SQL]
Support INSERT OVERWRITE [LOCAL] DIRECTORY '/path/â¦` is incomplete because it
is ending with
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/spark/pull/13067#issuecomment-218824134
@HyukjinKwon I don't understand your last comment
> ( it seems the last part of the title os truncated.)
---
If your project is set up for it, you
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r63059471
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r63059430
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoDir.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r63059450
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoDir.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the
Github user Parth-Brahmbhatt commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r63059349
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoDir.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the
Github user HyukjinKwon commented on the pull request:
https://github.com/apache/spark/pull/13067#issuecomment-218761425
( it seems the last part of the title os truncated.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r62963928
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/SaveAsHiveFile.scala
---
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r62963841
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoDir.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r62963804
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoDir.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/13067#discussion_r62963753
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoDir.scala
---
@@ -0,0 +1,137 @@
+/*
+ * Licensed to the Apache
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13067#issuecomment-218616342
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/spark/pull/13067#issuecomment-218615935
This is based off of @scwf's patch
https://github.com/apache/spark/pull/4380 so the credits should be given to him.
---
If your project is set up for it, you
GitHub user Parth-Brahmbhatt opened a pull request:
https://github.com/apache/spark/pull/13067
[SPARK-4131] [SQL] Support INSERT OVERWRITE [LOCAL] DIRECTORY '/path/â¦
## What changes were proposed in this pull request?
Support INSERT OVERWRITE [LOCAL] DIRECTORY
36 matches
Mail list logo
