Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2988#discussion_r19922788
--- Diff: ec2/spark_ec2.py ---
@@ -718,12 +726,16 @@ def get_num_disks(instance_type):
return 1
-# Deploy the configuration file
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/2988#discussion_r19922838
--- Diff: ec2/spark_ec2.py ---
@@ -718,12 +726,16 @@ def get_num_disks(instance_type):
return 1
-# Deploy the configuration file
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2988#discussion_r19923159
--- Diff: ec2/spark_ec2.py ---
@@ -718,12 +726,16 @@ def get_num_disks(instance_type):
return 1
-# Deploy the configuration file
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2988#discussion_r19923233
--- Diff: ec2/spark_ec2.py ---
@@ -718,12 +726,16 @@ def get_num_disks(instance_type):
return 1
-# Deploy the configuration file
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61919739
[Test build #22977 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22977/consoleFull)
for PR 2988 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61919824
[Test build #22977 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22977/consoleFull)
for PR 2988 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61919827
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61920803
[Test build #22981 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22981/consoleFull)
for PR 2988 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61926208
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61926204
[Test build #22981 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22981/consoleFull)
for PR 2988 at commit
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61927044
Thanks @nchammas -- Merged this and backported to 1.2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/2988
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2988#discussion_r19746328
--- Diff: ec2/spark_ec2.py ---
@@ -718,12 +726,16 @@ def get_num_disks(instance_type):
return 1
-# Deploy the configuration file
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61006247
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61006242
[Test build #22464 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22464/consoleFull)
for PR 2988 at commit
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61007294
cc @shivaram @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61008323
@nchammas does the template replacement code still work correctly ? I am
referring to the deploy.generic dir that we pass from
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61009937
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61009928
[Test build #22465 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22465/consoleFull)
for PR 2988 at commit
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61013749
@shivaram Oh. Glad I pinged you. :)
In my brief testing I didn't allow `launch` to go all the way through. This
is obviously broken.
Will update this
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61016125
Actually, we have a few options here for `spark-ec2` and the underlying
`spark_ec2.py` script.
1. We leave the script as-is and just document the fact that
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61021907
Thanks for taking a closer look ! I don't know much python, but can't we
get the directory that the script is in using something like `__file__` and
prefix that to
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61023615
So basically you're saying go with option 2, right?
From what I can see, `deploy.generic` may be the only file we need to fix
the path for. Is that right? Maybe
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61029892
[Test build #22501 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22501/consoleFull)
for PR 2988 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61035007
[Test build #22501 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/22501/consoleFull)
for PR 2988 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61035013
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user nchammas commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61041277
@shivaram I took your suggestion and tested to make sure `spark-ec2` still
creates a functioning EC2 cluster.
This is ready for another review.
---
If your
Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/2988#discussion_r19586967
--- Diff: ec2/spark_ec2.py ---
@@ -718,12 +726,16 @@ def get_num_disks(instance_type):
return 1
-# Deploy the configuration file
Github user shivaram commented on the pull request:
https://github.com/apache/spark/pull/2988#issuecomment-61043164
Functionality LGTM. I left a minor style question for @JoshRosen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nchammas commented on a diff in the pull request:
https://github.com/apache/spark/pull/2988#discussion_r19587131
--- Diff: ec2/spark_ec2.py ---
@@ -718,12 +726,16 @@ def get_num_disks(instance_type):
return 1
-# Deploy the configuration file
30 matches
Mail list logo
