[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-11 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62517262 Jenkins, this is ok to test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62517782 [Test build #23212 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23212/consoleFull) for PR 3177 at commit

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-11 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62527255 [Test build #23212 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/23212/consoleFull) for PR 3177 at commit

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-11 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62527264 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-11 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62527448 @maji2014 Thanks for this fix. Merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/3177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-10 Thread maji2014
Github user maji2014 commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62363954 Yes, the test cases are all passed although exception throws before each test case. you can run SparkSinkSuite.scala directly and know the appearance like

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-10 Thread tdas
Github user tdas commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62491505 @maji2014 Correct, I verified this error after adding a log4j properties in the `external/flume-sink/src/test/resources` and seeing the log4j logs. And manually verified

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-10 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3177#discussion_r20128469 --- Diff: external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala --- @@ -159,6 +159,7 @@ class SparkSinkSuite extends

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-10 Thread harishreedharan
Github user harishreedharan commented on a diff in the pull request: https://github.com/apache/spark/pull/3177#discussion_r20129588 --- Diff: external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala --- @@ -159,6 +159,7 @@ class SparkSinkSuite

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-10 Thread maji2014
Github user maji2014 commented on a diff in the pull request: https://github.com/apache/spark/pull/3177#discussion_r20130942 --- Diff: external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala --- @@ -159,6 +159,7 @@ class SparkSinkSuite

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-10 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3177#discussion_r20130997 --- Diff: external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala --- @@ -159,6 +159,7 @@ class SparkSinkSuite extends

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-10 Thread tdas
Github user tdas commented on a diff in the pull request: https://github.com/apache/spark/pull/3177#discussion_r20131009 --- Diff: external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala --- @@ -159,6 +159,7 @@ class SparkSinkSuite extends

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-10 Thread maji2014
Github user maji2014 commented on a diff in the pull request: https://github.com/apache/spark/pull/3177#discussion_r20132263 --- Diff: external/flume-sink/src/test/scala/org/apache/spark/streaming/flume/sink/SparkSinkSuite.scala --- @@ -159,6 +159,7 @@ class SparkSinkSuite

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-09 Thread maji2014
GitHub user maji2014 opened a pull request: https://github.com/apache/spark/pull/3177 [SPARK-4295][External]Fix exception in SparkSinkSuite Handle exception in SparkSinkSuite, please refer to [SPARK-4295] You can merge this pull request into a Git repository by running: $ git

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62308120 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] spark pull request: [SPARK-4295][External]Fix exception in SparkSi...

2014-11-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/3177#issuecomment-62321381 Can you clarify how the tests pass if an exception is thrown? does that also need a fix? --- If your project is set up for it, you can reply to this email and have your