[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-12 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-78137745 [Test build #28437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28437/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/4696 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-78153146 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-78156585 [Test build #28443 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28443/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-78153133 [Test build #28437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28437/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-10 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-78155716 Hi Sean - I've added those fixes. I missed that last set of comments you mentioned. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-78158307 Test FAILed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-78153808 Looking good but there is still a set of small changes I think need to be made in the last diff in this PR to be consistent with the rest of the text. See my notes there.

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-10 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-78168971 [Test build #28443 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28443/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-10 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-78168975 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-77944782 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r26078952 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-77944766 [Test build #28400 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28400/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r26079757 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r26079822 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r26080074 --- Diff: docs/programming-guide.md --- @@ -1005,7 +1068,8 @@ for details. /tr tr td bforeach/b(ifunc/i) /td - td Run a function ifunc/i

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-09 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-77950519 Yep, I think it does need one more pass of edits but is 99% there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r26079924 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-09 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-77930399 [Test build #28400 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28400/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598261 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598561 --- Diff: docs/programming-guide.md --- @@ -1005,7 +1068,8 @@ for details. /tr tr td bforeach/b(ifunc/i) /td - td Run a function ifunc/i

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598357 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598471 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25598156 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25597775 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-03-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25597664 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,69 @@ def doStuff(self, rdd): /div +### Understanding closures a

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-24 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75875715 Hi all - does this need anything else prior to being merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread rxin
Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25054127 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,61 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25101597 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25102665 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25101857 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread ilganeli
Github user ilganeli commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25107441 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25101943 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25101966 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25102953 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75331901 Hi Josh - I pulled in your suggestions. Please let me know if anything else needs work. Thanks! --- If your project is set up for it, you can reply to this email and

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75332525 [Test build #27794 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27794/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25101554 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25103091 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75278730 [Test build #27779 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27779/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread ilganeli
Github user ilganeli commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75277825 Hi @rxin, thanks for the feedback. I've updated the doc, please let me know what you think. --- If your project is set up for it, you can reply to this email and have

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread JoshRosen
Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/4696#discussion_r25102714 --- Diff: docs/programming-guide.md --- @@ -728,6 +728,63 @@ def doStuff(self, rdd): /div +### Understanding closures +One of the

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75294320 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75294305 [Test build #27779 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27779/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75341387 [Test build #27794 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27794/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-20 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75341400 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75119774 [Test build #27728 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27728/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-19 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75119787 Test PASSed. Refer to this link for build results (access rights to CI server needed):

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-19 Thread SparkQA
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/4696#issuecomment-75105823 [Test build #27728 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27728/consoleFull) for PR 4696 at commit

[GitHub] spark pull request: [SPARK-4423] Improve foreach() documentation t...

2015-02-19 Thread ilganeli
GitHub user ilganeli opened a pull request: https://github.com/apache/spark/pull/4696 [SPARK-4423] Improve foreach() documentation to avoid confusion between local- and cluster-mode behavior Hi all - I've added a writeup on how closures work within Spark to help clarify the