Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72614700
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72614694
[Test build #26639 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26639/consoleFull)
for PR 4325 at commit
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/4325#discussion_r23988701
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DateUtils.scala ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4325#discussion_r23988264
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DateUtils.scala ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72613604
[Test build #26639 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26639/consoleFull)
for PR 4325 at commit
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/4325#discussion_r23990278
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DateUtils.scala ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72615808
[Test build #26642 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26642/consoleFull)
for PR 4325 at commit
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72615722
retest this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/4325
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72625660
[Test build #26642 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26642/consoleFull)
for PR 4325 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72625668
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/4325#discussion_r23990833
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DateUtils.scala ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3732
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-72563968
Thanks! Merging to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user adrian-wang opened a pull request:
https://github.com/apache/spark/pull/4325
[SPARK-4508] [SQL] build native date type to conform behavior to Hive
The previous #3732 is reverted due to some test failure.
Have fixed that.
You can merge this pull request into a Git
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72602223
Thanks for the quick fix.
LGTM pending tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/4325#discussion_r23987594
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DateUtils.scala ---
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72607626
[Test build #26617 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26617/consoleFull)
for PR 4325 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72607632
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4325#issuecomment-72601441
[Test build #26617 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26617/consoleFull)
for PR 4325 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71795113
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71796516
[Test build #26216 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26216/consoleFull)
for PR 3732 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71796124
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71796119
[Test build #26215 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26215/consoleFull)
for PR 3732 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71797621
[Test build #26210 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26210/consoleFull)
for PR 3732 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71797625
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71795022
[Test build #26215 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26215/consoleFull)
for PR 3732 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71795107
[Test build #26213 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26213/consoleFull)
for PR 3732 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71803990
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71803978
[Test build #26216 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26216/consoleFull)
for PR 3732 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r23628599
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
@@ -252,7 +252,7 @@ trait Row extends Serializable {
*
* @throws
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71607951
Thanks for working on this!
I took a quick look and it looks good. @yhuai can you do a more careful
review?
---
If your project is set up for it, you can reply to
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71609833
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71609830
[Test build #26148 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26148/consoleFull)
for PR 3732 at commit
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r23669844
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
@@ -252,7 +252,7 @@ trait Row extends Serializable {
*
* @throws
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r23670603
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
@@ -252,7 +252,7 @@ trait Row extends Serializable {
*
* @throws
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71791681
[Test build #26210 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26210/consoleFull)
for PR 3732 at commit
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r23669693
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
@@ -252,7 +252,7 @@ trait Row extends Serializable {
*
* @throws
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r23670522
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
@@ -252,7 +252,7 @@ trait Row extends Serializable {
*
* @throws
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71794073
[Test build #26213 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26213/consoleFull)
for PR 3732 at commit
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r23670356
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/Row.scala ---
@@ -252,7 +252,7 @@ trait Row extends Serializable {
*
* @throws
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71597172
[Test build #26146 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26146/consoleFull)
for PR 3732 at commit
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71600826
cc @rxin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71602934
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71601166
[Test build #26148 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26148/consoleFull)
for PR 3732 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-71602931
[Test build #26146 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/26146/consoleFull)
for PR 3732 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-70594597
Ping me when you are done updating this. Would be great to get into 1.3.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-70208781
Adrian - as we spoke offline, it would be simpler (for future datetime
related features) to just represent the Date type as a primitive int
internally, and convert to
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-70039985
[Test build #25595 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25595/consoleFull)
for PR 3732 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-70043756
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-70043753
[Test build #25595 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25595/consoleFull)
for PR 3732 at commit
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22990193
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -344,6 +345,11 @@ private[hive] trait HiveInspectors {
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-70039420
According to https://docs.oracle.com/javase/7/docs/api/java/sql/Date.html
To conform with the definition of SQL DATE, the millisecond values wrapped
by a
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22955597
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Date.scala
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22955717
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Date.scala
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22955622
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Date.scala
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22955738
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Date.scala
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22955914
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
@@ -344,6 +345,11 @@ private[hive] trait HiveInspectors {
case _:
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69961857
Thanks for working on this. I made some comments removing methods exposed.
Overall I favor minimalism in API design, because a simpler, smaller API is
easier to learn. Not
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69966856
To be clear, can you list all the problems when java.sql.Date is used in
the context of Hive? Please list all the differences. Thanks.
---
If your project is set up for
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69882069
@adrian-wang https://github.com/apache/spark/pull/3958 has been merged. Can
you bring this PR up to date?
---
If your project is set up for it, you can reply to this email
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69882219
[Test build #25525 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25525/consoleFull)
for PR 3732 at commit
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69882319
Yes, I have just done the rebasing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69883249
[Test build #25525 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25525/consoleFull)
for PR 3732 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69883254
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22921828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22921778
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22921859
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22921819
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22921862
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22922016
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22921998
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22922007
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22922060
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/java/Row.scala
---
@@ -125,6 +126,7 @@ object Row {
case seq: scala.collection.Seq[_] =
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22922206
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/pythonUdfs.scala ---
@@ -137,6 +138,8 @@ object EvaluatePython {
case (dec:
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22922237
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
---
@@ -253,7 +250,7 @@ case class Cast(child: Expression, dataType:
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69884677
BTW one question I have - what is wrong with just using java.util.Date but
trim the precision to date level?
---
If your project is set up for it, you can reply to this
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69886900
We cannot decide what java.util.Date is, it is parent of both java.sql.Date
and java.sql.Timestamp.
---
If your project is set up for it, you can reply to this
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69887287
Then why can't we use java.sql.Date?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22924040
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22924099
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/api/java/Row.scala
---
@@ -125,6 +126,7 @@ object Row {
case seq: scala.collection.Seq[_]
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22924204
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3732#discussion_r22924226
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/date/Date.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69889826
We were using java.sql.Date originally, but it did not conform with hive...
with different ordering definition(Though we can modify what we do when
comparing, it
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69890328
[Test build #25535 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25535/consoleFull)
for PR 3732 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69890660
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69890654
[Test build #25535 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25535/consoleFull)
for PR 3732 at commit
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69904110
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69904104
[Test build #25543 has
finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25543/consoleFull)
for PR 3732 at commit
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69896079
[Test build #25543 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25543/consoleFull)
for PR 3732 at commit
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69487182
Actually can we merge this after we merge
https://github.com/apache/spark/pull/3958 ?
So @adrian-wang you will likely need to do a slightly larger rebase (should
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69523451
Sure, I'll wait #3958 till it is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-69479299
Hmm, okay. Thanks for doing the research! Can you fix the conflict so we
can merge please?
/cc @rxin more api considerations...
---
If your project is set
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-68815238
For oracle's doc about `java.sql.Date`, In
https://docs.oracle.com/javase/6/docs/api/java/sql/Date.html
To conform with the definition of SQL DATE, the
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-68618363
[Test build #25022 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25022/consoleFull)
for PR 3732 at commit
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-68618384
Hi @marmbrus I have tried MySQL, and MySQL will treat cast('2015-01-03
18:25:04' as date) == cast('2015-01-03 18:29:02' as date), there is such a
precision lost.
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-68618399
The code seems conflict now, I have just rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user adrian-wang commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-68620569
and MySQL doesn't allow to cast date back to timestamp type
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-68390917
I'm a little confused about what semantics various systems are providing
here. Does java.sql.Data provide greater precision that hive? If so, I'm not
sure if we want
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3732#issuecomment-68243880
[Test build #24862 has
started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24862/consoleFull)
for PR 3732 at commit
1 - 100 of 146 matches
Mail list logo
